Add extension support to InspectorSonarPlugin

Summary:
This mirrors the extension support added to the desktop plugin and allows people to dynamically
add extension commands

Reviewed By: danielbuechele

Differential Revision: D8691167

fbshipit-source-id: 60136b960f8bbdfa42b2077d1f5f7b391fc44443
This commit is contained in:
Hilal Alsibai
2018-07-03 16:25:28 -07:00
committed by Facebook Github Bot
parent 44f561a683
commit e6fa377d75
3 changed files with 60 additions and 16 deletions

View File

@@ -62,7 +62,7 @@ public class InspectorSonarPluginTest {
@Test
public void testOnConnect() throws Exception {
final InspectorSonarPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment);
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final SonarConnection connection = new SonarConnectionMock();
plugin.onConnect(connection);
@@ -72,7 +72,7 @@ public class InspectorSonarPluginTest {
@Test
public void testOnDisconnect() throws Exception {
final InspectorSonarPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment);
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final SonarConnection connection = new SonarConnectionMock();
plugin.onConnect(connection);
@@ -83,7 +83,7 @@ public class InspectorSonarPluginTest {
@Test
public void testGetRoot() throws Exception {
final InspectorSonarPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment);
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final SonarResponderMock responder = new SonarResponderMock();
final SonarConnectionMock connection = new SonarConnectionMock();
plugin.onConnect(connection);
@@ -109,7 +109,7 @@ public class InspectorSonarPluginTest {
@Test
public void testGetNodes() throws Exception {
final InspectorSonarPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment);
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final SonarResponderMock responder = new SonarResponderMock();
final SonarConnectionMock connection = new SonarConnectionMock();
plugin.onConnect(connection);
@@ -145,7 +145,7 @@ public class InspectorSonarPluginTest {
@Test
public void testGetNodesThatDontExist() throws Exception {
final InspectorSonarPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment);
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final SonarResponderMock responder = new SonarResponderMock();
final SonarConnectionMock connection = new SonarConnectionMock();
plugin.onConnect(connection);
@@ -171,7 +171,7 @@ public class InspectorSonarPluginTest {
@Test
public void testSetData() throws Exception {
final InspectorSonarPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment);
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final SonarConnectionMock connection = new SonarConnectionMock();
final SonarResponderMock responder = new SonarResponderMock();
plugin.onConnect(connection);
@@ -207,7 +207,7 @@ public class InspectorSonarPluginTest {
@Test
public void testSetHighlighted() throws Exception {
final InspectorSonarPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment);
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final SonarConnectionMock connection = new SonarConnectionMock();
final SonarResponderMock responder = new SonarResponderMock();
plugin.onConnect(connection);
@@ -236,7 +236,7 @@ public class InspectorSonarPluginTest {
@Test
public void testHitTest() throws Exception {
final InspectorSonarPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment);
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final SonarConnectionMock connection = new SonarConnectionMock();
plugin.onConnect(connection);
@@ -273,7 +273,7 @@ public class InspectorSonarPluginTest {
@Test
public void testSetSearchActive() throws Exception {
final InspectorSonarPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment);
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final SonarConnectionMock connection = new SonarConnectionMock();
final SonarResponderMock responder = new SonarResponderMock();
plugin.onConnect(connection);
@@ -295,7 +295,7 @@ public class InspectorSonarPluginTest {
@Test(expected = AssertionError.class)
public void testNullChildThrows() throws Exception {
final InspectorSonarPlugin plugin =
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment);
new InspectorSonarPlugin(mApp, mDescriptorMapping, mScriptingEnvironment, null);
final SonarResponderMock responder = new SonarResponderMock();
final SonarConnectionMock connection = new SonarConnectionMock();
plugin.onConnect(connection);