From e6d8844cebc54f07100c127b0cbe17d4aab355b5 Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Mon, 30 Sep 2019 06:30:56 -0700 Subject: [PATCH] Potential fix for console proxying Summary: My hypothesis is that on hot reloads / `Ctrl+R`s calls to `this.log` from within the proxy would call the proxy itself. So the only truly relevant change here should be the `.bind(this)` removal. But I'm still not 100% sure that this was the reason for the stack overflow error. Let's keep an eye on this. Reviewed By: jknoxville Differential Revision: D17664509 fbshipit-source-id: c9e1c5fe32048b04ef0585f7162bd00ad5ccf18a --- types/nodejs.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/types/nodejs.tsx b/types/nodejs.tsx index 1e490a05f..1e5bd7e56 100644 --- a/types/nodejs.tsx +++ b/types/nodejs.tsx @@ -13,5 +13,6 @@ declare module NodeJS { window: Window | undefined; WebSocket: any; fetch: any; + originalConsole: Console | undefined; } }