From e67ed8030d4ec0b70ba07c71eb9914bcbfc0dc69 Mon Sep 17 00:00:00 2001
From: Michel Weststrate <mweststrate@fb.com>
Date: Fri, 22 Jan 2021 02:01:46 -0800
Subject: [PATCH] Make settings dialog scrollable

Summary: Make settings dialog content scrollable, which is more natural than scrolling the entire window, as reported in https://fb.workplace.com/groups/flippersupport/permalink/1063196077494383/

Reviewed By: nikoant

Differential Revision: D26015864

fbshipit-source-id: 8c74e105c290e62313e332ed1b47040eff548a97
---
 desktop/app/src/chrome/SettingsSheet.tsx | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/desktop/app/src/chrome/SettingsSheet.tsx b/desktop/app/src/chrome/SettingsSheet.tsx
index 46146c8b1..3548701f2 100644
--- a/desktop/app/src/chrome/SettingsSheet.tsx
+++ b/desktop/app/src/chrome/SettingsSheet.tsx
@@ -104,8 +104,12 @@ class SettingsSheet extends Component<Props, State> {
         onCancel={this.props.onHide}
         width={570}
         title="Settings"
-        footer={footer}>
-        <FlexColumn>{contents}</FlexColumn>
+        footer={footer}
+        bodyStyle={{
+          overflow: 'scroll',
+          maxHeight: 'calc(100vh - 250px)',
+        }}>
+        {contents}
       </Modal>
     );
   }