jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix NPE in DataTable

Browse Source 
Summary: Fixed linked NPE. Couldn't find a clear reproduction,

Reviewed By: passy

Differential Revision: D28958704

fbshipit-source-id: e09830fbad08bf035c54049451de7f52485cb9dc
This commit is contained in:
Michel Weststrate
2021-06-08 04:42:44 -07:00
committed by Facebook GitHub Bot
parent f3f0756da7
commit e6495be902
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
desktop/flipper-plugin/src/ui/data-table/DataTable.tsx
View File

@@ -238,7 +238,12 @@ export function DataTable<T extends object>(
let handled = true; let handled = true;
const shiftPressed = e.shiftKey; const shiftPressed = e.shiftKey;
const outputSize = dataSource.view.size; const outputSize = dataSource.view.size;
const windowSize = virtualizerRef.current!.virtualItems.length; const windowSize = props.scrollable
? virtualizerRef.current?.virtualItems.length ?? 0
: dataSource.view.size;
if (!windowSize) {
return;
}
switch (e.key) { switch (e.key) {
case 'ArrowUp': case 'ArrowUp':
tableManager.selectItem( tableManager.selectItem(
@@ -282,7 +287,7 @@ export function DataTable<T extends object>(
e.preventDefault(); e.preventDefault();
} }
}, },
[dataSource, tableManager], [dataSource, tableManager, props.scrollable],
); );
const [debouncedSetFilter] = useState(() => { const [debouncedSetFilter] = useState(() => {