jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move the code related to plugin loading / installation to "flipper-plugin-lib"

Browse Source 
Summary:
Sorry for so long diff, but actually there are no functional changes, just refactoring to make further changes of Plugin Manager easier to understand.

I've de-coupled the code related to plugin management from UI code and moved it from PluginInstaller UI component (which will be replaced soon by new UI) to "flipper-plugin-lib".  So pretty much everything related to plugin discovery and installation now consolidated in this package.

Additionally, this refactoring enables re-using of plugin management code in "flipper-pkg", e.g. to create CLI command for plugin installation from NPM, e.g.: `flipper-pkg install flipper-plugin-reactotron`.

Reviewed By: passy

Differential Revision: D23679346

fbshipit-source-id: 82e7b9de9afa08c508c1b228c2038b4ba423571c
This commit is contained in:
Anton Nikolaev
2020-09-16 06:30:20 -07:00
committed by Facebook GitHub Bot
parent 72ff87d7cd
commit e48707151a
18 changed files with 1274 additions and 483 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
desktop/app/src/dispatcher/pluginManager.tsx
View File

@@ -10,10 +10,10 @@
import {Store} from '../reducers/index';
import {Logger} from '../fb-interfaces/Logger';
import {registerInstalledPlugins} from '../reducers/pluginManager';
import {getPendingAndInstalledPlugins} from 'flipper-plugin-lib';
import {getInstalledPlugins} from 'flipper-plugin-lib';
function refreshInstalledPlugins(store: Store) {
getPendingAndInstalledPlugins().then((plugins) =>
getInstalledPlugins().then((plugins) =>
store.dispatch(registerInstalledPlugins(plugins)),
);
}