jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary ts-ignore for archive

Browse Source 
Summary:
This is a pretty broad ignore which doesn't seem required
but could hide real bugs.

Reviewed By: jknoxville

Differential Revision: D17342033

fbshipit-source-id: c7941e383936e44e39eff3fb7eced1d85a0d6417
This commit is contained in:
Pascal Hartig
2019-09-12 08:03:15 -07:00
committed by Facebook Github Bot
parent 64373aac0a
commit e25c1e7aaf
1 changed files with 11 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/devices/ArchivedDevice.tsx
View File

@@ -7,8 +7,17 @@
import BaseDevice from './BaseDevice'; import BaseDevice from './BaseDevice';
import {DeviceType, OS, DeviceShell, DeviceLogEntry} from './BaseDevice'; import {DeviceType, OS, DeviceShell, DeviceLogEntry} from './BaseDevice';
function normalizeArchivedDeviceType(deviceType: DeviceType): DeviceType {
let archivedDeviceType = deviceType;
if (archivedDeviceType === 'emulator') {
archivedDeviceType = 'archivedEmulator';
} else if (archivedDeviceType === 'physical') {
archivedDeviceType = 'archivedPhysical';
}
return archivedDeviceType;
}
export default class ArchivedDevice extends BaseDevice { export default class ArchivedDevice extends BaseDevice {
// @ts-ignore: Super needs to be on the first line
constructor( constructor(
serial: string, serial: string,
deviceType: DeviceType, deviceType: DeviceType,
@@ -16,13 +25,7 @@ export default class ArchivedDevice extends BaseDevice {
os: OS, os: OS,
logEntries: Array<DeviceLogEntry>, logEntries: Array<DeviceLogEntry>,
) { ) {
let archivedDeviceType = deviceType; super(serial, normalizeArchivedDeviceType(deviceType), title, os);
if (archivedDeviceType === 'emulator') {
archivedDeviceType = 'archivedEmulator';
} else if (archivedDeviceType === 'physical') {
archivedDeviceType = 'archivedPhysical';
}
super(serial, archivedDeviceType, title, os);
this.logs = logEntries; this.logs = logEntries;
} }