jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use localhost instead of hardcoded IP address

Browse Source 
Summary:
We can only do this when adb reverse is available, i.e. on Android 5+.
This also relies on a recent change to flipper desktop, to always run adb reverse on emulators.

Reviewed By: danielbuechele

Differential Revision: D10302579

fbshipit-source-id: cff07f0311d413fdd49424a42c641dfb3d225f7c
This commit is contained in:
John Knox
2018-12-18 07:28:20 -08:00
committed by Facebook Github Bot
parent ee0b640c30
commit e23da69db9
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
android/src/main/java/com/facebook/flipper/android/AndroidFlipperClient.java
View File

@@ -89,7 +89,10 @@ public final class AndroidFlipperClient {
}
static String getServerHost(Context context) {
if (isRunningOnStockEmulator()) {
if (isRunningOnStockEmulator() && Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {
// adb reverse was added in lollipop, so before this
// hard code host ip address.
// This means it will only work on emulators, not physical devices.
return "10.0.2.2";
} else if (isRunningOnGenymotion()) {
// This is hand-wavy but works on but ipv4 and ipv6 genymotion
@@ -98,7 +101,8 @@ public final class AndroidFlipperClient {
final int ip = info.getIpAddress();
return String.format("%d.%d.%d.2", (ip & 0xff), (ip >> 8 & 0xff), (ip >> 16 & 0xff));
} else {
// Running on physical device. Flipper desktop will run `adb reverse tcp:8088 tcp:8088`
// Running on physical device or modern stock emulator.
// Flipper desktop will run `adb reverse` to forward the ports.
return "localhost";
}
}