Distinguish between failures and things that we knowingly dont support
Summary: A lot of the failures in the dashboard are due to unsupported android devices. We can track this individually, but it shouldn't be affecting how reliable we think things are. This adds an Error type, that when thrown, adds an extra field to log messages to specify that it's a known incompatibility. Reviewed By: passy Differential Revision: D15394863 fbshipit-source-id: 9d7948fbb8c94bd7a64434496e10392532a61eed
This commit is contained in:
committed by
Facebook Github Bot
parent
a64a2a31e5
commit
e1aa6c4cd8
@@ -11,6 +11,7 @@
|
||||
* arguments.
|
||||
*/
|
||||
import {getAdbClient} from './adbClient';
|
||||
import {UnsupportedError} from './metrics';
|
||||
const adbkit = require('adbkit-fb');
|
||||
|
||||
const allowedAppNameRegex = /^[a-zA-Z0-9._\-]+$/;
|
||||
@@ -89,7 +90,7 @@ function executeCommandAsApp(
|
||||
);
|
||||
}
|
||||
if (output.toLowerCase().match(operationNotPermittedRegex)) {
|
||||
throw new Error(
|
||||
throw new UnsupportedError(
|
||||
`Your android device (${deviceId}) does not support the adb shell run-as command. We're tracking this at https://github.com/facebook/flipper/issues/92`,
|
||||
);
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user