From dec5045fcac328b295b2a74953cb64ddb720f890 Mon Sep 17 00:00:00 2001 From: Chaiwat Ekkaewnumchai Date: Tue, 26 May 2020 05:48:03 -0700 Subject: [PATCH] Fix Unwanted Highlight in ManagedTable Summary: Previously, rows got highlighted after switching between data for `ManagedTable` even though `highlightableRows` was set to false. This diff forces the highlighting not to happen when the value is set to false Reviewed By: mweststrate Differential Revision: D21720266 fbshipit-source-id: 534944fe03ad1561bc2109468ae6c4c5f3fc947d --- desktop/app/src/ui/components/table/ManagedTable.tsx | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/desktop/app/src/ui/components/table/ManagedTable.tsx b/desktop/app/src/ui/components/table/ManagedTable.tsx index 3a678745d..7a90223a9 100644 --- a/desktop/app/src/ui/components/table/ManagedTable.tsx +++ b/desktop/app/src/ui/components/table/ManagedTable.tsx @@ -402,6 +402,10 @@ export class ManagedTable extends React.Component< } onHighlight = (e: React.MouseEvent, row: TableBodyRow, index: number) => { + if (!this.props.highlightableRows) { + return; + } + if (e.shiftKey) { // prevents text selection e.preventDefault();