check for action type in application reducer

Summary: Previously, accidentally all action payloads have been written to the application reducer, because it didn't check the action type. Now, this diff makes sure, the application reducer checks for the action type and only writes actions to the store which are meant for the reducer.

Reviewed By: jknoxville

Differential Revision: D9179305

fbshipit-source-id: 833776468ed32e0385058571130e81eff06c370e

src/reducers/application.js

@@ -42,18 +42,28 @@ export default function reducer(
   state: State = INITIAL_STATE,
   action: Action,
 ): State {
-  const newValue =
+  const {payload, type} = action;
-    typeof action.payload === 'undefined'
+  const newValue = typeof payload === 'undefined' ? !state[type] : payload;
-      ? !state[action.type]
+
-      : action.payload;
+  if (
-  if (state[action.type] === newValue) {
+    type === 'leftSidebarVisible' ||
-    // value hasn't changed, do nothing
+    type === 'rightSidebarVisible' ||
-    return state;
+    type === 'rightSidebarAvailable' ||
+    type === 'bugDialogVisible' ||
+    type === 'windowIsFocused' ||
+    type === 'pluginManagerVisible'
+  ) {
+    if (state[type] === newValue) {
+      // value hasn't changed
+      return state;
+    } else {
+      return {
+        ...state,
+        [type]: newValue,
+      };
+    }
   } else {
-    return {
+    return state;
-      ...state,
-      [action.type]: newValue,
-    };
   }
 }