From de5147a516f88209073757ff15ffcccbfcbb26c3 Mon Sep 17 00:00:00 2001 From: Dan Melnic Date: Thu, 30 Apr 2020 13:27:53 -0700 Subject: [PATCH] Add support for io_uring based async read/recvmsg Summary: Add support for io_uring based async read/recvmsg (Note: this ignores all push blocking failures!) Reviewed By: kevin-vigor Differential Revision: D21208891 fbshipit-source-id: 21b3b5e0f201e982ecb50a284d03ab53413ec3e3 --- iOS/FlipperKitTests/FlipperClientTests.mm | 32 +++++++++++------------ 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/iOS/FlipperKitTests/FlipperClientTests.mm b/iOS/FlipperKitTests/FlipperClientTests.mm index 45cdc1004..67ac27988 100644 --- a/iOS/FlipperKitTests/FlipperClientTests.mm +++ b/iOS/FlipperKitTests/FlipperClientTests.mm @@ -25,18 +25,18 @@ @implementation FlipperClientTests facebook::flipper::FlipperClient* client; -facebook::flipper::test::FlipperConnectionManagerMock* socket; +facebook::flipper::test::FlipperConnectionManagerMock* sock; FlipperClient* objcClient; - (void)setUp { // Put setup code here. This method is called before the invocation of each // test method in the class. - socket = new facebook::flipper::test::FlipperConnectionManagerMock; + sock = new facebook::flipper::test::FlipperConnectionManagerMock; auto state = std::make_shared(); client = new facebook::flipper::FlipperClient( std::unique_ptr{ - socket}, + sock}, state); objcClient = [[FlipperClient alloc] initWithCppClient:client]; } @@ -84,7 +84,7 @@ FlipperClient* objcClient; std::unique_ptr responder = std::make_unique( &successes, &errors); - socket->callbacks->onMessageReceived(message, std::move(responder)); + sock->callbacks->onMessageReceived(message, std::move(responder)); folly::dynamic expected = folly::dynamic::object("plugins", folly::dynamic::array()); XCTAssertEqual(successes.size(), 1); @@ -146,7 +146,7 @@ FlipperClient* objcClient; std::unique_ptr responder = std::make_unique(); - socket->callbacks->onMessageReceived(messageInit, std::move(responder)); + sock->callbacks->onMessageReceived(messageInit, std::move(responder)); XCTAssertTrue(pluginConnected); [objcClient stop]; XCTAssertFalse(pluginConnected); @@ -172,19 +172,19 @@ FlipperClient* objcClient; "params", folly::dynamic::object("plugin", "cat")); std::unique_ptr responder = std::make_unique(); - socket->callbacks->onMessageReceived(messageInit, std::move(responder)); + sock->callbacks->onMessageReceived(messageInit, std::move(responder)); XCTAssertTrue(pluginConnected); folly::dynamic messageDeInit = folly::dynamic::object("method", "deinit")( "params", folly::dynamic::object("plugin", "cat")); std::unique_ptr responder2 = std::make_unique(); - socket->callbacks->onMessageReceived(messageDeInit, std::move(responder2)); + sock->callbacks->onMessageReceived(messageDeInit, std::move(responder2)); XCTAssertFalse(pluginConnected); std::unique_ptr responder3 = std::make_unique(); - socket->callbacks->onMessageReceived(messageInit, std::move(responder3)); + sock->callbacks->onMessageReceived(messageInit, std::move(responder3)); XCTAssertTrue(pluginConnected); [objcClient stop]; @@ -212,7 +212,7 @@ FlipperClient* objcClient; std::unique_ptr responder = std::make_unique(); XCTAssertNoThrow( - socket->callbacks->onMessageReceived(messageInit, std::move(responder))); + sock->callbacks->onMessageReceived(messageInit, std::move(responder))); XCTAssertTrue(pluginConnected); } @@ -235,7 +235,7 @@ FlipperClient* objcClient; "params", folly::dynamic::object("plugin", "cat")); std::unique_ptr responder = std::make_unique(); - socket->callbacks->onMessageReceived(messageInit, std::move(responder)); + sock->callbacks->onMessageReceived(messageInit, std::move(responder)); XCTAssertNoThrow( [objcClient stop]); // Stopping client will call disconnect of the plugin @@ -264,7 +264,7 @@ FlipperClient* objcClient; "params", folly::dynamic::object("plugin", "PluginIdentifier")); std::unique_ptr responder1 = std::make_unique(); - socket->callbacks->onMessageReceived(messageInit, std::move(responder1)); + sock->callbacks->onMessageReceived(messageInit, std::move(responder1)); folly::dynamic message = folly::dynamic::object("id", 1)("method", "execute")( "params", folly::dynamic::object("api", "PluginIdentifier")( @@ -272,7 +272,7 @@ FlipperClient* objcClient; std::unique_ptr responder2 = std::make_unique(); - socket->callbacks->onMessageReceived(message, std::move(responder2)); + sock->callbacks->onMessageReceived(message, std::move(responder2)); XCTAssertTrue(isCalled); } @@ -300,7 +300,7 @@ FlipperClient* objcClient; "params", folly::dynamic::object("plugin", "PluginIdentifier")); std::unique_ptr responder = std::make_unique(); - socket->callbacks->onMessageReceived(messageInit, std::move(responder)); + sock->callbacks->onMessageReceived(messageInit, std::move(responder)); folly::dynamic message = folly::dynamic::object("id", 1)("method", "execute")( "params", @@ -308,7 +308,7 @@ FlipperClient* objcClient; "method", "MethodName")); std::unique_ptr responder2 = std::make_unique(); - socket->callbacks->onMessageReceived(message, std::move(responder2)); + sock->callbacks->onMessageReceived(message, std::move(responder2)); XCTAssertTrue(isCalled); } @@ -338,7 +338,7 @@ FlipperClient* objcClient; "params", folly::dynamic::object("plugin", "PluginIdentifier")); std::unique_ptr responder = std::make_unique(); - socket->callbacks->onMessageReceived(messageInit, std::move(responder)); + sock->callbacks->onMessageReceived(messageInit, std::move(responder)); folly::dynamic message = folly::dynamic::object("id", 1)("method", "execute")( "params", @@ -351,7 +351,7 @@ FlipperClient* objcClient; &successes, &errors); XCTAssertNoThrow( - socket->callbacks->onMessageReceived(message, std::move(responder2))); + sock->callbacks->onMessageReceived(message, std::move(responder2))); XCTAssertTrue(isCalled); XCTAssertEqual(successes.size(), 0); XCTAssertEqual(errors.size(), 1);