jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

explicitly report errors in MainThreadFlipperReceiver

Browse Source 
Summary: Use responder rather than allowing exception to propagate.

Reviewed By: jknoxville

Differential Revision: D14538883

fbshipit-source-id: 2774a2adfcee356e1853fa3bf3c01aa113181262
This commit is contained in:
Vlad Albulescu
2019-03-27 08:02:15 -07:00
committed by Facebook Github Bot
parent b2d1506f15
commit de46240272
2 changed files with 72 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
android/src/main/java/com/facebook/flipper/plugins/common/MainThreadFlipperReceiver.java
View File

@@ -9,32 +9,47 @@ package com.facebook.flipper.plugins.common;
import android.os.Handler;
import android.os.Looper;
import com.facebook.flipper.core.ErrorReportingRunnable;
import com.facebook.flipper.core.FlipperConnection;
import com.facebook.flipper.core.FlipperObject;
import com.facebook.flipper.core.FlipperReceiver;
import com.facebook.flipper.core.FlipperResponder;
import java.io.PrintWriter;
import java.io.StringWriter;
public abstract class MainThreadFlipperReceiver implements FlipperReceiver {
public MainThreadFlipperReceiver(FlipperConnection connection) {
this.mConnection = connection;
// TODO(T41065412): remove unused constructor argument.
}
private final FlipperConnection mConnection;
private final Handler mHandler = new Handler(Looper.getMainLooper());
@Override
public final void onReceive(final FlipperObject params, final FlipperResponder responder) {
mHandler.post(
new ErrorReportingRunnable(mConnection) {
new Runnable() {
@Override
public void runOrThrow() throws Exception {
onReceiveOnMainThread(params, responder);
public void run() {
try {
onReceiveOnMainThread(params, responder);
} catch (Exception ex) {
responder.error(
new FlipperObject.Builder()
.put("name", ex.getClass().getCanonicalName())
.put("message", ex.getMessage())
.put("stacktrace", getStackTraceString(ex))
.build());
}
}
});
}
private static String getStackTraceString(Throwable th) {
StringWriter stringWriter = new StringWriter();
th.printStackTrace(new PrintWriter(stringWriter));
return stringWriter.toString();
}
public abstract void onReceiveOnMainThread(FlipperObject params, FlipperResponder responder)
throws Exception;
}