From ddf348faa5ca2c77a7bc33271fe1a891165e2694 Mon Sep 17 00:00:00 2001
From: Lorenzo Blasa <lblasa@meta.com>
Date: Fri, 22 Sep 2023 10:31:15 -0700
Subject: [PATCH] Immediately close server if no clients are connected

Summary: ^

Reviewed By: ivanmisuno

Differential Revision: D49539483

fbshipit-source-id: ffbcffe0f0b0f31bc26ba5881b30ae27960c283e
---
 .../src/server/attachSocketServer.tsx         | 23 ++++++-------------
 1 file changed, 7 insertions(+), 16 deletions(-)

diff --git a/desktop/flipper-server-core/src/server/attachSocketServer.tsx b/desktop/flipper-server-core/src/server/attachSocketServer.tsx
index 9b8892106..0642078eb 100644
--- a/desktop/flipper-server-core/src/server/attachSocketServer.tsx
+++ b/desktop/flipper-server-core/src/server/attachSocketServer.tsx
@@ -39,7 +39,6 @@ const safe = (f: () => void) => {
 };
 
 let numberOfConnectedClients = 0;
-let disconnectTimeout: NodeJS.Timeout | undefined;
 
 /**
  * Attach and handle incoming messages from clients.
@@ -236,21 +235,13 @@ export function attachSocketServer(
       server.offAny(onServerEvent);
       flipperServerCompanion?.destroyAll();
 
-      if (getFlipperServerConfig().environmentInfo.isHeadlessBuild) {
-        if (disconnectTimeout) {
-          clearTimeout(disconnectTimeout);
-        }
-
-        if (closeOnIdle) {
-          /**
-           * If, after 60 seconds, there are no more connected clients, we exit the process.
-           */
-          disconnectTimeout = setTimeout(() => {
-            if (numberOfConnectedClients === 0 && isProduction()) {
-              console.info('Shutdown as no clients are currently connected');
-              process.exit(0);
-            }
-          }, 60 * 1000);
+      if (
+        getFlipperServerConfig().environmentInfo.isHeadlessBuild &&
+        closeOnIdle
+      ) {
+        if (numberOfConnectedClients === 0 && isProduction()) {
+          console.info('Shutdown as no clients are currently connected');
+          process.exit(0);
         }
       }
     }