Fix fb-stubs replacement for plugin bundling
Reviewed By: nikoant Differential Revision: D39765543 fbshipit-source-id: 14cbf8a9bdf35031e636bbbde3dbc955faedb66b
This commit is contained in:
committed by
Facebook GitHub Bot
parent
61a8fe09e9
commit
dd7ba2d6fc
@@ -39,23 +39,35 @@ export default class Bundle extends Command {
|
||||
'Force env.NODE_ENV=production, enable minification and disable producing source maps.',
|
||||
default: false,
|
||||
}),
|
||||
intern: flags.boolean({
|
||||
description: 'Force inten build which replaces fb-stubs with fb.',
|
||||
default: false,
|
||||
}),
|
||||
};
|
||||
|
||||
public async run() {
|
||||
const {args, flags} = this.parse(Bundle);
|
||||
const inputDirectory: string = path.resolve(process.cwd(), args.directory);
|
||||
const success = await runBuildOnce(inputDirectory, !flags.production);
|
||||
const success = await runBuildOnce(
|
||||
inputDirectory,
|
||||
!flags.production,
|
||||
flags.intern,
|
||||
);
|
||||
if (!flags.watch) {
|
||||
process.exit(success ? 0 : 1);
|
||||
} else {
|
||||
enterWatchMode(inputDirectory, !flags.production);
|
||||
enterWatchMode(inputDirectory, !flags.production, flags.intern);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
async function runBuildOnce(inputDirectory: string, dev: boolean) {
|
||||
async function runBuildOnce(
|
||||
inputDirectory: string,
|
||||
dev: boolean,
|
||||
intern: boolean,
|
||||
) {
|
||||
try {
|
||||
await runBuild(inputDirectory, dev);
|
||||
await runBuild(inputDirectory, dev, intern);
|
||||
console.log('✅ Build succeeded');
|
||||
return true;
|
||||
} catch (e) {
|
||||
@@ -65,7 +77,7 @@ async function runBuildOnce(inputDirectory: string, dev: boolean) {
|
||||
}
|
||||
}
|
||||
|
||||
function enterWatchMode(inputDirectory: string, dev: boolean) {
|
||||
function enterWatchMode(inputDirectory: string, dev: boolean, intern: boolean) {
|
||||
console.log(`⏳ Waiting for changes...`);
|
||||
let isBuilding = false;
|
||||
let pendingChanges = false;
|
||||
@@ -82,7 +94,7 @@ function enterWatchMode(inputDirectory: string, dev: boolean) {
|
||||
isBuilding = true;
|
||||
while (pendingChanges) {
|
||||
pendingChanges = false;
|
||||
await runBuildOnce(inputDirectory, dev);
|
||||
await runBuildOnce(inputDirectory, dev, intern);
|
||||
}
|
||||
isBuilding = false;
|
||||
console.log(`⏳ Waiting for changes...`);
|
||||
|
||||
@@ -40,6 +40,10 @@ export default class Pack extends Command {
|
||||
'Force env.NODE_ENV=production, enable minification and disable producing source maps.',
|
||||
default: false,
|
||||
}),
|
||||
intern: flags.boolean({
|
||||
description: 'Force inten build which replaces fb-stubs with fb.',
|
||||
default: false,
|
||||
}),
|
||||
};
|
||||
|
||||
public static args: args.IArg[] = [
|
||||
@@ -115,7 +119,7 @@ export default class Pack extends Command {
|
||||
cli.action.stop();
|
||||
|
||||
cli.action.start(`Compiling`);
|
||||
await runBuild(inputDirectory, parsedFlags.production);
|
||||
await runBuild(inputDirectory, parsedFlags.production, parsedFlags.intern);
|
||||
cli.action.stop();
|
||||
|
||||
cli.action.start(`Packing to ${outputFile}`);
|
||||
|
||||
Reference in New Issue
Block a user