Only use Flipper in DEBUG builds

Summary:
as discussed in https://github.com/facebook/flipper/issues/976#issuecomment-634917766,

this solves the issue that FlipperKit is accidentally included in production builds ones react-native-flipper is installed, due to it's dependency on Flipper kit

This change is safe because the bindings did already have a check to verify that the Flipper bindings are available at all, and silenty skips their absence in production builds: https://www.internalfb.com/intern/diffusion/FBS/browse/master/xplat/sonar/react-native/react-native-flipper/index.js?commit=b7dd7e05b177&lines=128

Reviewed By: passy

Differential Revision: D21749213

fbshipit-source-id: 2c4435c7a375fbc24f89159855d3e0297f3aa9a4
This commit is contained in:
Michel Weststrate
2020-05-28 09:54:17 -07:00
committed by Facebook GitHub Bot
parent febb3deed9
commit dd111076c9
6 changed files with 19 additions and 1 deletions

View File

@@ -457,6 +457,6 @@ SPEC CHECKSUMS:
Yoga: e0448a3eecac22245fae6ce1b291c557b93b06af Yoga: e0448a3eecac22245fae6ce1b291c557b93b06af
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a YogaKit: f782866e155069a2cca2517aafea43200b01fd5a
PODFILE CHECKSUM: ec00bac18470bff6bf1d2db889337b72b34a474a PODFILE CHECKSUM: f9f57fc88aa93cb64e0b46441cad586698bdfbef
COCOAPODS: 1.9.2 COCOAPODS: 1.9.2

View File

@@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree. * LICENSE file in the root directory of this source tree.
*/ */
#ifdef DEBUG
#import "FlipperModule.h" #import "FlipperModule.h"
#import "FlipperReactNativeJavaScriptPluginManager.h" #import "FlipperReactNativeJavaScriptPluginManager.h"
@@ -93,3 +94,5 @@ RCT_EXPORT_METHOD(respondError
} }
@end @end
#endif

View File

@@ -5,6 +5,7 @@
* LICENSE file in the root directory of this source tree. * LICENSE file in the root directory of this source tree.
*/ */
#if DEBUG
#import <FlipperKit/FlipperConnection.h> #import <FlipperKit/FlipperConnection.h>
#import <FlipperKit/FlipperPlugin.h> #import <FlipperKit/FlipperPlugin.h>
@@ -28,3 +29,5 @@ NS_ASSUME_NONNULL_BEGIN
@end @end
NS_ASSUME_NONNULL_END NS_ASSUME_NONNULL_END
#endif

View File

@@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree. * LICENSE file in the root directory of this source tree.
*/ */
#if DEBUG
#import "FlipperReactNativeJavaScriptPlugin.h" #import "FlipperReactNativeJavaScriptPlugin.h"
#import <FlipperKit/FlipperClient.h> #import <FlipperKit/FlipperClient.h>
@@ -61,3 +63,5 @@
} }
@end @end
#endif

View File

@@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree. * LICENSE file in the root directory of this source tree.
*/ */
#ifdef DEBUG
#import <React/RCTBridgeModule.h> #import <React/RCTBridgeModule.h>
#import <FlipperKit/FlipperClient.h> #import <FlipperKit/FlipperClient.h>
@@ -44,3 +46,5 @@ NS_ASSUME_NONNULL_BEGIN
@end @end
NS_ASSUME_NONNULL_END NS_ASSUME_NONNULL_END
#endif

View File

@@ -5,6 +5,8 @@
* LICENSE file in the root directory of this source tree. * LICENSE file in the root directory of this source tree.
*/ */
#ifdef DEBUG
#import "FlipperReactNativeJavaScriptPluginManager.h" #import "FlipperReactNativeJavaScriptPluginManager.h"
#import <FlipperKit/FlipperClient.h> #import <FlipperKit/FlipperClient.h>
#import <FlipperKit/FlipperPlugin.h> #import <FlipperKit/FlipperPlugin.h>
@@ -147,3 +149,5 @@ static uint32_t FlipperResponderKeyGenerator = 0;
} }
@end @end
#endif