jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add size prop to layout inspector

Browse Source 
Summary: Size is passed as a prop to every `CKComponent` and `CKFlexboxChild`. It is useful to see where it was set exactly

Reviewed By: kevin0571

Differential Revision: D16688496

fbshipit-source-id: 5f8dc39a967ab2d7d89d6a37a8152aa6b59db220
This commit is contained in:
Oleksii Dykan
2019-08-07 10:19:56 -07:00
committed by Facebook Github Bot
parent d0a3cb5f74
commit dbf0e3db43
4 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/CKComponent+Sonar.mm
View File

@@ -27,6 +27,7 @@
#import "CKInsetComponent+Sonar.h" #import "CKInsetComponent+Sonar.h"
#import "CKStatelessComponent+Sonar.h" #import "CKStatelessComponent+Sonar.h"
#import "FKDataStorageForLiveEditing.h" #import "FKDataStorageForLiveEditing.h"
#import "Utils.h"
/** This protocol isn't actually adopted anywhere, it just lets us use the SEL below */ /** This protocol isn't actually adopted anywhere, it just lets us use the SEL below */
@protocol SonarKitLayoutComponentKitOverrideInformalProtocol @protocol SonarKitLayoutComponentKitOverrideInformalProtocol
@@ -138,6 +139,7 @@ static CK::StaticMutex _mutex = CK_MUTEX_INITIALIZER;
withValue: @{ withValue: @{
@"frame": SKObject(self.viewContext.frame), @"frame": SKObject(self.viewContext.frame),
@"controller": SKObject(NSStringFromClass([self.controller class])), @"controller": SKObject(NSStringFromClass([self.controller class])),
@"size": SKObject(ckcomponentSize([self size])),
}]]; }]];
auto const canBeReusedCounter = self.flipper_canBeReusedCounter; auto const canBeReusedCounter = self.flipper_canBeReusedCounter;

1
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKComponentLayoutDescriptor.mm
View File

@@ -130,6 +130,7 @@
@"flexGrow": SKObject(@(child.flexGrow)), @"flexGrow": SKObject(@(child.flexGrow)),
@"flexShrink": SKObject(@(child.flexShrink)), @"flexShrink": SKObject(@(child.flexShrink)),
@"zIndex": SKObject(@(child.zIndex)), @"zIndex": SKObject(@(child.zIndex)),
@"sizeConstraints": SKObject(ckcomponentSize(child.sizeConstraints)),
@"useTextRounding": SKObject(@(child.useTextRounding)), @"useTextRounding": SKObject(@(child.useTextRounding)),
@"margin": flexboxRect(child.margin), @"margin": flexboxRect(child.margin),
@"flexBasis": relativeDimension(child.flexBasis), @"flexBasis": relativeDimension(child.flexBasis),

1
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/Utils.h
View File

@@ -10,3 +10,4 @@
NSString *relativeDimension(CKRelativeDimension dimension); NSString *relativeDimension(CKRelativeDimension dimension);
NSDictionary<NSString *, NSString *> *flexboxRect(CKFlexboxSpacing spacing); NSDictionary<NSString *, NSString *> *flexboxRect(CKFlexboxSpacing spacing);
CKRelativeDimension relativeStructDimension(NSString *dimension); CKRelativeDimension relativeStructDimension(NSString *dimension);
NSDictionary<NSString *, NSString *> *ckcomponentSize(CKComponentSize size);

11
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/Utils.mm
View File

@@ -39,4 +39,15 @@ NSDictionary<NSString *, NSString *> *flexboxRect(CKFlexboxSpacing spacing) {
}; };
} }
NSDictionary<NSString *, NSString *> *ckcomponentSize(CKComponentSize size) {
return @{
@"width": relativeDimension(size.width),
@"height": relativeDimension(size.height),
@"minWidth": relativeDimension(size.minWidth),
@"minHeight": relativeDimension(size.minHeight),
@"maxWidth": relativeDimension(size.maxWidth),
@"maxHeight": relativeDimension(size.maxHeight),
};
}
#endif #endif