Enforce promise chains lint

Summary: Setting the lint level to error and fixing the last three violations.

Reviewed By: nikoant

Differential Revision: D32109025

fbshipit-source-id: 213ecaa17317f665ac5a192682fa06d182c28581

desktop/.eslintrc.js

@@ -107,7 +107,7 @@ module.exports = {
     'communist-spelling/communist-spelling': [1, {allow: ['cancelled']}],
 
     // promise rules, see https://github.com/xjamundx/eslint-plugin-promise for details on each of them
-    'promise/catch-or-return': 'warn',
+    'promise/catch-or-return': 'error',
     'promise/no-nesting': 'warn',
     'promise/no-promise-in-callback': 'warn',
     'promise/no-callback-in-promise': 'warn',