jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixes the broken build of Sample app on open source

Browse Source 
Summary:
This diff fixes the broken sample app for xcode 11. Followed the remediation mentioned in the following links

https://github.com/Carthage/Carthage/issues/2825
https://twitter.com/krzyzanowskim/status/1151549874653081601?s=21

Remediation:

Adding Dummy swift file and assigning `"LD_VERIFY_BITCODE": "NO"` solves the problem as suggested in the above links

Reviewed By: jknoxville

Differential Revision: D18420954

fbshipit-source-id: e87930790329ffb2bb92c40aa197552efeedecd3
This commit is contained in:
Pritesh Nandgaonkar
2019-11-11 10:14:40 -08:00
committed by Facebook Github Bot
parent 93655d39b8
commit db9bd6c22e
5 changed files with 118 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
iOS/Sample/Dummy.swift Normal file
View File

@@ -0,0 +1,14 @@
/*
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*/
import Foundation
// Added this dummy swift file to solve the sample app's compilation issue for Xcode 11.
// Following are the links with the explanation for this fix.
// D18420963, D18420963
// https://github.com/Carthage/Carthage/issues/2825
// https://twitter.com/krzyzanowskim/status/1151549874653081601?s=21