diff --git a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ActivityDescriptor.kt b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ActivityDescriptor.kt index f794e7f1b..cdd28bd8f 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ActivityDescriptor.kt +++ b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ActivityDescriptor.kt @@ -13,30 +13,30 @@ import com.facebook.flipper.plugins.uidebugger.stetho.FragmentCompat object ActivityDescriptor : AbstractChainedDescriptor() { - override fun onGetId(activity: Activity): String { - return Integer.toString(System.identityHashCode(activity)) + override fun onGetId(node: Activity): String { + return System.identityHashCode(node).toString() } - override fun onGetName(activity: Activity): String { - return activity.javaClass.simpleName + override fun onGetName(node: Activity): String { + return node.javaClass.simpleName } - override fun onGetChildren(activity: Activity, children: MutableList) { - activity.window?.let { window -> children.add(activity.window) } + override fun onGetChildren(node: Activity, children: MutableList) { + node.window?.let { window -> children.add(window) } - var fragments = getDialogFragments(FragmentCompat.supportInstance, activity) + var fragments = getDialogFragments(FragmentCompat.supportInstance, node) for (fragment in fragments) { children.add(fragment) } - fragments = getDialogFragments(FragmentCompat.frameworkInstance, activity) + fragments = getDialogFragments(FragmentCompat.frameworkInstance, node) for (fragment in fragments) { children.add(fragment) } } override fun onGetData( - activity: Activity, + node: Activity, attributeSections: MutableMap ) {} diff --git a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ApplicationRefDescriptor.kt b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ApplicationRefDescriptor.kt index 534038b48..34d43760d 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ApplicationRefDescriptor.kt +++ b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ApplicationRefDescriptor.kt @@ -13,22 +13,22 @@ import com.facebook.flipper.plugins.uidebugger.core.ApplicationRef object ApplicationRefDescriptor : AbstractChainedDescriptor() { override fun onGetActiveChild(node: ApplicationRef): Any? { - return if (node.activitiesStack.size > 0) node.activitiesStack.last() else null + return if (node.activitiesStack.isNotEmpty()) node.activitiesStack.last() else null } - override fun onGetId(applicationRef: ApplicationRef): String { - return applicationRef.application.packageName + override fun onGetId(node: ApplicationRef): String { + return node.application.packageName } - override fun onGetName(applicationRef: ApplicationRef): String { - val applicationInfo = applicationRef.application.getApplicationInfo() + override fun onGetName(node: ApplicationRef): String { + val applicationInfo = node.application.applicationInfo val stringId = applicationInfo.labelRes return if (stringId == 0) applicationInfo.nonLocalizedLabel.toString() - else applicationRef.application.getString(stringId) + else node.application.getString(stringId) } - override fun onGetChildren(applicationRef: ApplicationRef, children: MutableList) { - for (activity: Activity in applicationRef.activitiesStack) { + override fun onGetChildren(node: ApplicationRef, children: MutableList) { + for (activity: Activity in node.activitiesStack) { children.add(activity) } } diff --git a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ButtonDescriptor.kt b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ButtonDescriptor.kt index ff040474e..9e5fb6b8c 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ButtonDescriptor.kt +++ b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ButtonDescriptor.kt @@ -12,16 +12,13 @@ import com.facebook.flipper.plugins.uidebugger.common.InspectableObject object ButtonDescriptor : AbstractChainedDescriptor