jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Disable electron tests

Browse Source 
Summary:
Turns out, we don't have any tests that _actually_ depend on Electron. What is more, the one test suite that was still left was actually failing for a long time, but somehow CI didn't pick and reported that :-P.

Note that I dropped the file `xplat/sonar/scripts/facebook/lego/run-sc-yarn-targets-with-electron.sh` entirely, as it appeared unused

Reviewed By: nikoant

Differential Revision: D22434441

fbshipit-source-id: 34df79a580a64904116ae93069bbc8fafc53d9d0
This commit is contained in:
Michel Weststrate
2020-07-10 04:27:33 -07:00
committed by Facebook GitHub Bot
parent 32933f4bf1
commit d90499be84
1 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
desktop/app/src/utils/__tests__/exportData.electron.tsx → desktop/app/src/utils/__tests__/exportData.node.tsx
View File

@@ -181,7 +181,9 @@ test('test processStore function for empty state', () => {
salt: 'salt', salt: 'salt',
selectedPlugins: [], selectedPlugins: [],
}); });
expect(json).resolves.toBeNull(); expect(json).rejects.toMatchInlineSnapshot(
`[Error: Selected device is null, please select a device]`,
);
}); });
test('test processStore function for an iOS device connected', async () => { test('test processStore function for an iOS device connected', async () => {
@@ -204,14 +206,12 @@ test('test processStore function for an iOS device connected', async () => {
}); });
if (!json) { if (!json) {
fail('json is undefined'); fail('json is undefined');
return;
} }
const {device, clients} = json; const {device, clients} = json;
expect(json.device).toBeDefined(); expect(json.device).toBeDefined();
expect(clients).toEqual([]); expect(clients).toEqual([]);
if (!device) { if (!device) {
fail('device is undefined'); fail('device is undefined');
return;
} }
const {serial, deviceType, title, os} = device; const {serial, deviceType, title, os} = device;
expect(serial).toEqual('salt-serial'); expect(serial).toEqual('salt-serial');
@@ -247,7 +247,6 @@ test('test processStore function for an iOS device connected with client plugin
}); });
if (!json) { if (!json) {
fail('json is undefined'); fail('json is undefined');
return;
} }
const {pluginStates} = json.store; const {pluginStates} = json.store;
const expectedPluginState = { const expectedPluginState = {
@@ -314,7 +313,6 @@ test('test processStore function to have only the client for the selected device
if (!json) { if (!json) {
fail('json is undefined'); fail('json is undefined');
return;
} }
const {clients} = json; const {clients} = json;
const {pluginStates} = json.store; const {pluginStates} = json.store;
@@ -375,7 +373,6 @@ test('test processStore function to have multiple clients for the selected devic
if (!json) { if (!json) {
fail('json is undefined'); fail('json is undefined');
return;
} }
const {clients} = json; const {clients} = json;
const {pluginStates} = json.store; const {pluginStates} = json.store;
@@ -423,7 +420,6 @@ test('test processStore function for device plugin state and no clients', async
if (!json) { if (!json) {
fail('json is undefined'); fail('json is undefined');
return;
} }
const {pluginStates} = json.store; const {pluginStates} = json.store;
const {clients} = json; const {clients} = json;
@@ -460,7 +456,6 @@ test('test processStore function for unselected device plugin state and no clien
}); });
if (!json) { if (!json) {
fail('json is undefined'); fail('json is undefined');
return;
} }
const {pluginStates} = json.store; const {pluginStates} = json.store;
const {clients} = json; const {clients} = json;
@@ -503,7 +498,6 @@ test('test processStore function for notifications for selected device', async (
if (!json) { if (!json) {
fail('json is undefined'); fail('json is undefined');
return;
} }
const {pluginStates} = json.store; const {pluginStates} = json.store;
const {clients} = json; const {clients} = json;
@@ -565,7 +559,6 @@ test('test processStore function for notifications for unselected device', async
}); });
if (!json) { if (!json) {
fail('json is undefined'); fail('json is undefined');
return;
} }
const {pluginStates} = json.store; const {pluginStates} = json.store;
const {clients} = json; const {clients} = json;
@@ -609,7 +602,6 @@ test('test processStore function for selected plugins', async () => {
}); });
if (!json) { if (!json) {
fail('json is undefined'); fail('json is undefined');
return;
} }
const {pluginStates} = json.store; const {pluginStates} = json.store;
const {clients} = json; const {clients} = json;
@@ -660,7 +652,6 @@ test('test processStore function for no selected plugins', async () => {
if (!json) { if (!json) {
fail('json is undefined'); fail('json is undefined');
return;
} }
const {pluginStates} = json.store; const {pluginStates} = json.store;
const {clients} = json; const {clients} = json;