From d897cfd7653968f38746f65d550bdc287c87cb07 Mon Sep 17 00:00:00 2001 From: Simek Date: Mon, 24 Jan 2022 02:32:36 -0800 Subject: [PATCH] fix Settings modal UI glitch with overlow in dark mode (#3330) Summary: This small tweak fixes the Setting modal UI glitch (white rectangle in the bottom right) related to the modal content overflow setting. ## Changelog * fix Settings modal UI glitch with content overflow setting in dark mode Pull Request resolved: https://github.com/facebook/flipper/pull/3330 Test Plan: The change has been testes by running the desktop Flipper app locally from source. ## Preview (before & after) #### No scrollbar Screenshot 2022-01-23 at 15 45 47 Screenshot 2022-01-23 at 15 45 39 #### With scrollbar Screenshot 2022-01-23 at 15 51 40 Screenshot 2022-01-23 at 15 51 47 Reviewed By: aigoncharov Differential Revision: D33738647 Pulled By: lblasa fbshipit-source-id: f5a170950271302241a29d4382c481f2ce8bf4ec --- desktop/flipper-ui-core/src/chrome/SettingsSheet.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop/flipper-ui-core/src/chrome/SettingsSheet.tsx b/desktop/flipper-ui-core/src/chrome/SettingsSheet.tsx index 75877ffea..e42de8536 100644 --- a/desktop/flipper-ui-core/src/chrome/SettingsSheet.tsx +++ b/desktop/flipper-ui-core/src/chrome/SettingsSheet.tsx @@ -98,7 +98,7 @@ class SettingsSheet extends Component { title="Settings" footer={footer} bodyStyle={{ - overflow: 'scroll', + overflow: 'auto', maxHeight: 'calc(100vh - 250px)', }}> {contents}