From d85e8a09498e687e9d77535ec8fc4d217dafffbf Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Tue, 20 Sep 2022 05:15:50 -0700 Subject: [PATCH] TreeObserverFactory, change file name to match type Summary: ^ Reviewed By: LukeDefeo Differential Revision: D39575384 fbshipit-source-id: 30ca896d93c4f3641f748123af024354c10de8b8 --- .../observers/{ObserverFactory.kt => TreeObserverFactory.kt} | 3 +++ 1 file changed, 3 insertions(+) rename android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/{ObserverFactory.kt => TreeObserverFactory.kt} (82%) diff --git a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/ObserverFactory.kt b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserverFactory.kt similarity index 82% rename from android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/ObserverFactory.kt rename to android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserverFactory.kt index ced9554a5..b4b0bd5fa 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/ObserverFactory.kt +++ b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserverFactory.kt @@ -22,10 +22,12 @@ class TreeObserverFactory { builders.add(builder) } + // TODO: Not very efficient, need to cache this. Builders cannot be removed fun hasObserverFor(node: Any): Boolean { return builders.any { it.canBuildFor(node) } } + // TODO: Not very efficient, need to cache this. Builders cannot be removed. fun createObserver(node: Any, context: Context): TreeObserver<*>? { return builders.find { it.canBuildFor(node) }?.build(context) } @@ -33,6 +35,7 @@ class TreeObserverFactory { companion object { fun withDefaults(): TreeObserverFactory { val factory = TreeObserverFactory() + // TODO: Only builder for DecorView, maybe more are needed. factory.register(DecorViewTreeObserverBuilder) return factory