jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix broken attribution of mount events

Browse Source 
Summary: The string were out of sync so using the constants instead

Reviewed By: fabiocarballo

Differential Revision: D49414046

fbshipit-source-id: 5d61831505e5d7ecec3d5c9717d4549ba4b291a8
This commit is contained in:
Luke De Feo
2023-09-19 06:14:25 -07:00
committed by Facebook GitHub Bot
parent b6f7d4c56f
commit d7f8ed5d81
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/UIDebuggerLithoSupport.kt
View File

@@ -20,6 +20,7 @@ import com.facebook.litho.MatrixDrawable
import com.facebook.litho.debug.LithoDebugEvent import com.facebook.litho.debug.LithoDebugEvent
import com.facebook.litho.widget.TextDrawable import com.facebook.litho.widget.TextDrawable
import com.facebook.rendercore.debug.DebugEvent import com.facebook.rendercore.debug.DebugEvent
import com.facebook.rendercore.debug.DebugEventAttribute
import com.facebook.rendercore.debug.DebugEventBus import com.facebook.rendercore.debug.DebugEventBus
import com.facebook.rendercore.debug.DebugEventSubscriber import com.facebook.rendercore.debug.DebugEventSubscriber
import com.facebook.rendercore.debug.DebugMarkerEvent import com.facebook.rendercore.debug.DebugMarkerEvent
@@ -77,13 +78,13 @@ object UIDebuggerLithoSupport {
val treeId = event.renderStateId.toIntOrNull() ?: -1 val treeId = event.renderStateId.toIntOrNull() ?: -1
val globalKey = val globalKey =
event.attributeOrNull<String>("Key")?.let { event.attributeOrNull<String>(DebugEventAttribute.Key)?.let {
DebugComponent.generateGlobalKey(treeId, it).hashCode() DebugComponent.generateGlobalKey(treeId, it).hashCode()
} }
val duration = event.attributeOrNull<Duration>("duration") val duration = event.attributeOrNull<Duration>(DebugEventAttribute.Duration)
val attributes = mutableMapOf<String, String>() val attributes = mutableMapOf<String, String>()
val source = event.attributeOrNull<String>("source") val source = event.attributeOrNull<String>(DebugEventAttribute.Source)
if (source != null) { if (source != null) {
attributes["source"] = source attributes["source"] = source
} }