From d7ecd3af5a406cd710655d5515dce2fdb3981001 Mon Sep 17 00:00:00 2001 From: Qichuan Date: Mon, 17 Dec 2018 09:54:03 -0800 Subject: [PATCH] Fixe the iOS UserDefaultsPlugin (#340) Summary: The `getAllSharedPreferences` API is not implemented in the iOS UserDefaultsPlugin and thus the data is not shown in the `Shared Preference Viewer`. This PR implements the missing API and present the Standard UserDefaults data from the target application. Pull Request resolved: https://github.com/facebook/flipper/pull/340 Reviewed By: danielbuechele Differential Revision: D13464765 Pulled By: priteshrnandgaonkar fbshipit-source-id: 8c6cf4e9f7094fcf75c71cce43cb6c34f9f957e7 --- .../FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.m | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/iOS/Plugins/FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.m b/iOS/Plugins/FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.m index 7275f7f6c..cae0e07ed 100644 --- a/iOS/Plugins/FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.m +++ b/iOS/Plugins/FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.m @@ -40,6 +40,13 @@ - (void)didConnect:(id)connection { self.flipperConnection = connection; + [connection receive:@"getAllSharedPreferences" withBlock:^(NSDictionary *params, id responder) { + NSDictionary *userDefaults = @{ + @"Standard UserDefaults": [self.userDefaults dictionaryRepresentation] + }; + [responder success: userDefaults]; + }]; + [connection receive:@"getSharedPreferences" withBlock:^(NSDictionary *params, id responder) { [responder success:[self.userDefaults dictionaryRepresentation]]; }]; @@ -73,7 +80,7 @@ } else { [params setObject:value forKey:@"value"]; } - + [params setObject:@"Standard UserDefaults" forKey:@"preferences"]; [self.flipperConnection send:@"sharedPreferencesChange" withParams:[params copy]]; }