jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix scrolling to inspected element

Browse Source 
Summary:
When the `Scrollable` component was introduced, this functionality regressed because the `ref` was no longer set on the right component.

changelog: Fix scrolling to inspected element in Layout plugin

Reviewed By: mweststrate

Differential Revision: D21979475

fbshipit-source-id: f84d515cb1593a33d1ae0e93a01681b6e11aa623
This commit is contained in:
Scott Kyle
2020-06-11 00:13:37 -07:00
committed by Facebook GitHub Bot
parent fb0af47c31
commit d6c97b48d3
2 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/app/src/ui/components/Scrollable.tsx
View File

@@ -13,7 +13,7 @@ import {BackgroundProperty} from 'csstype';
type Props = {children: React.ReactNode; background?: BackgroundProperty<any>}; type Props = {children: React.ReactNode; background?: BackgroundProperty<any>};
const Scrollable: React.FC<Props> = styled('div')<Props>(({background}) => ({ const Scrollable = styled.div<Props>(({background}) => ({
width: '100%', width: '100%',
height: '100%', height: '100%',
overflow: 'auto', overflow: 'auto',

7
desktop/app/src/ui/components/elements-inspector/elements.tsx
View File

@@ -702,11 +702,8 @@ export class Elements extends PureComponent<ElementsProps, ElementsState> {
render() { render() {
return ( return (
<Scrollable> <Scrollable ref={this._outerRef}>
<ElementsContainer <ElementsContainer onKeyDown={this.onKeyDown} tabIndex={0}>
onKeyDown={this.onKeyDown}
tabIndex={0}
ref={this._outerRef}>
{this.state.flatElements.map(this.buildRow)} {this.state.flatElements.map(this.buildRow)}
</ElementsContainer> </ElementsContainer>
</Scrollable> </Scrollable>