From d66484822bafaa7934145ee6d9ab4c01d157575a Mon Sep 17 00:00:00 2001 From: Adam Ernst Date: Tue, 21 Apr 2020 11:51:02 -0700 Subject: [PATCH] Allow subdescriptors to return nil to signal no data Summary: Currently subdescriptors are *always* rendered. Allow them to return `nil` to signal that they don't need to be rendered. Reviewed By: cuva Differential Revision: D21157249 fbshipit-source-id: 68a83424efc50723e1ec71c069feef8e10037671 --- .../SKComponentLayoutDescriptor.mm | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKComponentLayoutDescriptor.mm b/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKComponentLayoutDescriptor.mm index 36425a5c0..01952afb8 100644 --- a/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKComponentLayoutDescriptor.mm +++ b/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/SKComponentLayoutDescriptor.mm @@ -102,7 +102,10 @@ static std::vector>& subDescriptors() { [[NSMutableDictionary alloc] init]; for (const auto& pair : subDescriptors()) { - [extraData setObject:pair.second(node) forKey:pair.first]; + NSString* value = pair.second(node); + if (value) { + [extraData setObject:value forKey:pair.first]; + } } if (extraData.count > 0) { [data addObject:[SKNamed newWithName:@"Extra Sections"