Support physical device logging
Summary: Changelog: Logs plugin now supports physical iOS devices As reported in https://github.com/facebook/flipper/issues/262 and linked papercut. This diff adds support for iOS device logs through idb. Since idb doesn't respect `--json` flag at the moment, we perform the parsing in Flipper itself. Reviewed By: passy Differential Revision: D27346262 fbshipit-source-id: 3b314716f48bb9a7fe709370303396a51893359c
This commit is contained in:
committed by
Facebook GitHub Bot
parent
d22e893169
commit
d5fbe9a5b9
@@ -35,7 +35,7 @@ export type ExtendedLogEntry = DeviceLogEntry & {
|
||||
};
|
||||
|
||||
function createColumnConfig(
|
||||
os: 'iOS' | 'Android' | 'Metro',
|
||||
_os: 'iOS' | 'Android' | 'Metro',
|
||||
): DataTableColumn<ExtendedLogEntry>[] {
|
||||
return [
|
||||
{
|
||||
@@ -74,7 +74,7 @@ function createColumnConfig(
|
||||
key: 'pid',
|
||||
title: 'PID',
|
||||
width: 60,
|
||||
visible: os === 'Android',
|
||||
visible: true,
|
||||
},
|
||||
{
|
||||
key: 'tid',
|
||||
|
||||
@@ -4,10 +4,25 @@
|
||||
"id": "DeviceLogs",
|
||||
"pluginType": "device",
|
||||
"supportedDevices": [
|
||||
{"os": "Android", "type": "emulator"},
|
||||
{"os": "Android", "type": "physical"},
|
||||
{"os": "iOS", "type": "emulator"},
|
||||
{"os": "Metro"}
|
||||
{
|
||||
"os": "Android",
|
||||
"type": "emulator"
|
||||
},
|
||||
{
|
||||
"os": "Android",
|
||||
"type": "physical"
|
||||
},
|
||||
{
|
||||
"os": "iOS",
|
||||
"type": "emulator"
|
||||
},
|
||||
{
|
||||
"os": "iOS",
|
||||
"type": "physical"
|
||||
},
|
||||
{
|
||||
"os": "Metro"
|
||||
}
|
||||
],
|
||||
"version": "0.0.0",
|
||||
"main": "dist/bundle.js",
|
||||
|
||||
Reference in New Issue
Block a user