Cleaned up deviceType enum

Summary:
The device type enum was mixing two different concepts (emulator vs physical) and (archived vs not), and we already have a separate `isArchived` field. So cleaned this up to not leak it into sandy.

If anybody can think of any unforeseen consequences of this, lemme know :)

Reviewed By: jknoxville

Differential Revision: D22763506

fbshipit-source-id: bd2f7dbd1d2d2e6942ba7c6ddd8dc91ee34d591d

desktop/flipper-plugin/src/test-utils/test-utils.tsx

@@ -341,6 +341,8 @@ export function createMockPluginDetails(
 function createMockDevice(options?: StartPluginOptions): RealFlipperDevice {
   const logListeners: (undefined | DeviceLogListener)[] = [];
   return {
+    os: 'Android',
+    deviceType: 'emulator',
     isArchived: !!options?.isArchived,
     addLogListener(cb) {
       logListeners.push(cb);