Cleaned up deviceType enum

Summary:
The device type enum was mixing two different concepts (emulator vs physical) and (archived vs not), and we already have a separate `isArchived` field. So cleaned this up to not leak it into sandy.

If anybody can think of any unforeseen consequences of this, lemme know :)

Reviewed By: jknoxville

Differential Revision: D22763506

fbshipit-source-id: bd2f7dbd1d2d2e6942ba7c6ddd8dc91ee34d591d

desktop/app/src/devices/BaseDevice.tsx

@@ -14,6 +14,7 @@ import {
   DeviceLogEntry,
   SandyDevicePluginInstance,
   SandyPluginDefinition,
+  DeviceType,
 } from 'flipper-plugin';
 import {DevicePluginMap, FlipperDevicePlugin} from '../plugin';
 
@@ -23,12 +24,6 @@ export type DeviceShell = {
   stdin: stream.Writable;
 };
 
-export type DeviceType =
-  | 'emulator'
-  | 'physical'
-  | 'archivedEmulator'
-  | 'archivedPhysical';
-
 export type DeviceExport = {
   os: OS;
   title: string;