From d4d2937c80ba8fa989273fb38b6d62150fb5240c Mon Sep 17 00:00:00 2001 From: Paco Estevez Garcia Date: Sun, 6 Sep 2020 12:57:02 -0700 Subject: [PATCH] Fix setting layoutParams fromLayout Editor Summary: The function `setLayoutParams` expects the values to be set to be at array position 0+, and they were on position 1+ instead. This effectively prevented users from setting LayoutParameters. Reviewed By: muraziz Differential Revision: D23538531 fbshipit-source-id: cc828363ee8d7408d1df29d98c37b09893826bb1 --- .../plugins/inspector/descriptors/ViewDescriptor.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewDescriptor.java b/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewDescriptor.java index 8372e631b..743e0b510 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewDescriptor.java +++ b/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/ViewDescriptor.java @@ -230,7 +230,10 @@ public class ViewDescriptor extends NodeDescriptor { node.setVisibility(sVisibilityMapping.get(value.asString())); break; case "layoutParams": - setLayoutParams(node, Arrays.copyOfRange(path, 1, path.length), value); + // path is [view, layoutParams, value] and we only want the values + if (path.length > 2) { + setLayoutParams(node, Arrays.copyOfRange(path, 2, path.length), value); + } break; case "layoutDirection": node.setLayoutDirection(sLayoutDirectionMapping.get(value.asString()));