jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Logs: cleaned up warnings because of duplicate keys in context menu

Browse Source 
Summary: In dev build there were tons of warnings on opening table context menu, because some items had same keys. This diff fixes that by differentiating item keys.

Reviewed By: mweststrate

Differential Revision: D33277520

fbshipit-source-id: aca2fa2f1163a2b6782be0ca4c5baebdecc5acd5
This commit is contained in:
Anton Nikolaev
2021-12-22 15:33:08 -08:00
committed by Facebook GitHub Bot
parent dd4d7bbe7f
commit d48fbd8e50
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
desktop/flipper-plugin/src/ui/data-table/TableContextMenu.tsx
View File

@@ -111,7 +111,7 @@ export function tableContextMenuFactory<T>(
</Item> </Item>
{lib.isFB && ( {lib.isFB && (
<Item <Item
key="createPaste" key="createPasteJSON"
disabled={!hasSelection} disabled={!hasSelection}
onClick={() => { onClick={() => {
const items = getSelectedItems(datasource, selection); const items = getSelectedItems(datasource, selection);
@@ -131,7 +131,7 @@ export function tableContextMenuFactory<T>(
disabled={!hasSelection}> disabled={!hasSelection}>
{visibleColumns.map((column, idx) => ( {visibleColumns.map((column, idx) => (
<Item <Item
key={column.key ?? idx} key={'copy cell' + (column.key ?? idx)}
onClick={() => { onClick={() => {
const items = getSelectedItems(datasource, selection); const items = getSelectedItems(datasource, selection);
if (items.length) { if (items.length) {
@@ -147,7 +147,7 @@ export function tableContextMenuFactory<T>(
<Menu.Divider /> <Menu.Divider />
<SubMenu title="Visible columns" key="visible columns"> <SubMenu title="Visible columns" key="visible columns">
{columns.map((column, idx) => ( {columns.map((column, idx) => (
<Menu.Item key={column.key ?? idx}> <Menu.Item key={'visible column ' + (column.key ?? idx)}>
<Checkbox <Checkbox
checked={column.visible} checked={column.visible}
onClick={(e) => { onClick={(e) => {