Address lints

Summary: Just going through all the lints that have popped up.

Reviewed By: jknoxville

Differential Revision: D24078571

fbshipit-source-id: 06504aafa969eea92ee934ac607d3daf51e47914

packer/src/error.rs

@@ -20,14 +20,14 @@ impl std::error::Error for Error {}
 impl fmt::Display for Error {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
         match self {
-            Error::MissingPackFile(platform, pack_type, path) => write!(
+            Self::MissingPackFile(platform, pack_type, path) => write!(
                 f,
                 "Couldn't open file to pack for platform {:?} and type {:?}: {}",
                 platform,
                 pack_type,
                 path.to_string_lossy()
             ),
-            Error::MissingPlatformDefinition(platform) => write!(
+            Self::MissingPlatformDefinition(platform) => write!(
                 f,
                 "Platform {} is not defined in the given packlist.",
                 platform