Add rule for warning against electron.remote

Summary:
I don't think there's an easy way to do this based on types
which would be ideal ...

So instead I'm checking for

- Importing `remote` from `electron`.
- Accessing `electron.remote`.

You can still hack this by importing `electron`, saving
it to a differently named variable and accessing `remote` on it,
but this should cover all reasonable cases we see in real code.

Reviewed By: mweststrate

Differential Revision: D26453006

fbshipit-source-id: 4b3d223bed43ca3f0d1a4f592ea8f8060a823479

desktop/eslint-plugin-flipper/src/rules/__tests__/noElectronRemoteImports.node.ts

@@ -0,0 +1,53 @@
+/**
+ * Copyright (c) Facebook, Inc. and its affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+import {TSESLint} from '@typescript-eslint/experimental-utils';
+import rule, {RULE_NAME} from '../noElectronRemoteImports';
+
+const tester = new TSESLint.RuleTester({
+  parser: require.resolve('@typescript-eslint/parser'),
+  parserOptions: {
+    sourceType: 'module',
+    ecmaVersion: 2020,
+  },
+});
+
+tester.run(RULE_NAME, rule, {
+  valid: [
+    {
+      code: `import {something} from 'electron';`,
+      filename: __filename,
+    },
+    {
+      code: `import remote from 'electron';`,
+      filename: __filename,
+    },
+    {
+      code: `import remote from './electron';`,
+      filename: __filename,
+    },
+  ],
+  invalid: [
+    {
+      code: `import {remote} from 'electron';`,
+      filename: __filename,
+      errors: [{messageId: 'noElectronRemoteImports'}],
+    },
+    {
+      code: `import {remote, somethingelse} from 'electron';`,
+      filename: __filename,
+      errors: [{messageId: 'noElectronRemoteImports'}],
+    },
+    {
+      code: `import {remote as notRemote} from 'electron';`,
+      filename: __filename,
+      errors: [{messageId: 'noElectronRemoteImports'}],
+    },
+  ],
+});