Add rule for warning against electron.remote

Summary:
I don't think there's an easy way to do this based on types
which would be ideal ...

So instead I'm checking for

- Importing `remote` from `electron`.
- Accessing `electron.remote`.

You can still hack this by importing `electron`, saving
it to a differently named variable and accessing `remote` on it,
but this should cover all reasonable cases we see in real code.

Reviewed By: mweststrate

Differential Revision: D26453006

fbshipit-source-id: 4b3d223bed43ca3f0d1a4f592ea8f8060a823479
This commit is contained in:
Pascal Hartig
2021-02-16 04:14:04 -08:00
committed by Facebook GitHub Bot
parent fe3a6bd55e
commit d42932c111
4 changed files with 118 additions and 0 deletions

View File

@@ -10,9 +10,13 @@
import noRelativeImportsAcrossPackages, {
RULE_NAME as noRelativeImportsAcrossPackagesRuleName,
} from './rules/noRelativeImportsAcrossPackages';
import noElectronRemoteImports, {
RULE_NAME as noElectronRemoteImportsRuleName,
} from './rules/noElectronRemoteImports';
module.exports = {
rules: {
[noRelativeImportsAcrossPackagesRuleName]: noRelativeImportsAcrossPackages,
[noElectronRemoteImportsRuleName]: noElectronRemoteImports,
},
};