From d37f1c282a358cf83f301052249a753319915307 Mon Sep 17 00:00:00 2001
From: Michel Weststrate <mweststrate@fb.com>
Date: Wed, 17 Feb 2021 08:17:37 -0800
Subject: [PATCH] Fixed issue with reseting logs

Summary:
Noticed that subsequent `adb logcat` invocations are stateful, and we didn't clear it's state when clearing the logs in memory.

This is a bandaid to get back to the previous behavior. I am wondering whether it wouldn't be just much more intuitive to always clear the logs (`adb logcat -c`) before we start the streaming log listener, so that users are never shown old logs from before flipper was connected?

Also fixed a leak in cleaning up the log listeners that was revealed by the possibility to disable the log plugin

Reviewed By: nikoant

Differential Revision: D26450262

fbshipit-source-id: 5b426e2d0e1fafdbc512d48d22b7bd4f30b61309
---
 .../app/src/sandy-chrome/appinspect/LaunchEmulator.tsx    | 6 ++++--
 desktop/flipper-plugin/src/plugin/PluginBase.tsx          | 8 ++++++--
 desktop/plugins/logs/index.tsx                            | 2 ++
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/desktop/app/src/sandy-chrome/appinspect/LaunchEmulator.tsx b/desktop/app/src/sandy-chrome/appinspect/LaunchEmulator.tsx
index 56b54ee5b..dde7d8e4c 100644
--- a/desktop/app/src/sandy-chrome/appinspect/LaunchEmulator.tsx
+++ b/desktop/app/src/sandy-chrome/appinspect/LaunchEmulator.tsx
@@ -76,7 +76,9 @@ export const LaunchEmulatorDialog = withTrackingScope(
     }, [iosEnabled, getSimulators, store]);
 
     const items = [
-      ...(androidEmulators.length > 0 ? [<AndroidOutlined />] : []),
+      ...(androidEmulators.length > 0
+        ? [<AndroidOutlined key="android logo" />]
+        : []),
       ...androidEmulators.map((name) => {
         const launch = (coldBoot: boolean) => {
           launchEmulator(name, coldBoot)
@@ -111,7 +113,7 @@ export const LaunchEmulatorDialog = withTrackingScope(
           </Dropdown.Button>
         );
       }),
-      ...(iosEmulators.length > 0 ? [<AppleOutlined />] : []),
+      ...(iosEmulators.length > 0 ? [<AppleOutlined key="ios logo" />] : []),
       ...iosEmulators.map((device) => (
         <Button
           key={device.udid}
diff --git a/desktop/flipper-plugin/src/plugin/PluginBase.tsx b/desktop/flipper-plugin/src/plugin/PluginBase.tsx
index 9fbb1c76d..9a4376e63 100644
--- a/desktop/flipper-plugin/src/plugin/PluginBase.tsx
+++ b/desktop/flipper-plugin/src/plugin/PluginBase.tsx
@@ -115,6 +115,7 @@ export abstract class BasePluginInstance {
   importHandler?: StateImportHandler;
 
   menuEntries: NormalizedMenuEntry[] = [];
+  logListeners: Symbol[] = [];
 
   constructor(
     flipperLib: FlipperLib,
@@ -139,9 +140,9 @@ export abstract class BasePluginInstance {
         return realDevice.connected.get();
       },
       deviceType: realDevice.deviceType,
-
-      onLogEntry(cb) {
+      onLogEntry: (cb) => {
         const handle = realDevice.addLogListener(cb);
+        this.logListeners.push(handle);
         return () => {
           realDevice.removeLogListener(handle);
         };
@@ -265,6 +266,9 @@ export abstract class BasePluginInstance {
   destroy() {
     this.assertNotDestroyed();
     this.deactivate();
+    this.logListeners.splice(0).forEach((handle) => {
+      this.device.realDevice.removeLogListener(handle);
+    });
     this.events.emit('destroy');
     this.destroyed = true;
   }
diff --git a/desktop/plugins/logs/index.tsx b/desktop/plugins/logs/index.tsx
index aad737d7c..2a96bc294 100644
--- a/desktop/plugins/logs/index.tsx
+++ b/desktop/plugins/logs/index.tsx
@@ -497,6 +497,8 @@ export function devicePlugin(client: DevicePluginClient) {
   }
 
   function clearLogs() {
+    // Non public Android specific api
+    (client.device.realDevice as any)?.clearLogs?.();
     entries.set([]);
     rows.set([]);
     highlightedRows.set(new Set());