jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Skip Android health-checks when the "Android Developer" option is disabled in Flipper settings

Browse Source 
Summary:
Skip Android health-checks when the "Android Developer" option is disabled in Flipper settings.

Also made some refactoring to use immer for healthcheck reducer.

Reviewed By: mweststrate

Differential Revision: D19088322

fbshipit-source-id: 801d874b6e7e5af80802b4bf4313d98f1cee13f6
This commit is contained in:
Anton Nikolaev
2019-12-16 16:35:49 -08:00
committed by Facebook Github Bot
parent be53990613
commit d32774f439
6 changed files with 256 additions and 188 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
src/reducers/__tests__/healthchecks.node.tsx
View File

@@ -14,7 +14,8 @@ import {
HealthcheckReportCategory,
HealthcheckReportItem,
finishHealthchecks,
updateHealthcheckReportItem,
updateHealthcheckReportItemStatus,
updateHealthcheckReportCategoryStatus,
} from '../healthchecks';
const HEALTHCHECK_ITEM: HealthcheckReportItem = {
@@ -70,14 +71,14 @@ test('updateHealthcheck', () => {
let res = reducer(undefined, initHealthcheckReport(report));
res = reducer(
res,
updateHealthcheckReportItem(0, 0, {
label: 'Updated Test Item',
updateHealthcheckReportItemStatus(0, 0, {
message: 'Updated Test Message',
status: 'SUCCESS',
}),
);
expect(res.healthcheckReport.isHealthcheckInProgress).toBeTruthy();
expect(res.healthcheckReport.categories[0].checks[0].label).toEqual(
'Updated Test Item',
expect(res.healthcheckReport.categories[0].checks[0].message).toEqual(
'Updated Test Message',
);
expect(res.healthcheckReport.categories[0].checks[0].status).toEqual(
'SUCCESS',
@@ -89,3 +90,24 @@ test('updateHealthcheck', () => {
'WARNING',
);
});
test('updateHealthcheckCategoryStatus', () => {
const report = {
isHealthcheckInProgress: true,
categories: [HEALTHCHECK_CATEGORY, HEALTHCHECK_CATEGORY],
};
let res = reducer(undefined, initHealthcheckReport(report));
res = reducer(
res,
updateHealthcheckReportCategoryStatus(1, {
status: 'FAILED',
message: 'Error message',
}),
);
expect(res.healthcheckReport.isHealthcheckInProgress).toBeTruthy();
expect(res.healthcheckReport.categories[0].label).toEqual('Test Category');
expect(res.healthcheckReport.categories[0].status).toEqual('WARNING');
expect(res.healthcheckReport.categories[1].label).toEqual('Test Category');
expect(res.healthcheckReport.categories[1].status).toEqual('FAILED');
expect(res.healthcheckReport.categories[1].message).toEqual('Error message');
});