Remove dynamic dependencies from flipper-server

Summary:
Currently, Flipper Server has a few productions dependencies (mac-ca, node-fetch) that are not bundled with the Flipper Server. It makes it harder to distribute Flipper Server, as now all potential consumers need not only to download the bundle, but also install these additional dependencies.
This diff makes it possible to bundle `mac-ca` and `node-fetch` with Flipper Server. As a result, Flipper Server becomes dependency-free in production.

Reviewed By: lblasa

Differential Revision: D36345213

fbshipit-source-id: 2cd6ba1b3301b45dc2295891964ba020fd107586
This commit is contained in:
Andrey Goncharov
2022-05-13 03:19:47 -07:00
committed by Facebook GitHub Bot
parent 21dfeca756
commit d1ed676a48
14 changed files with 190 additions and 38 deletions

View File

@@ -46,10 +46,10 @@ export const BUILTINS = [
'repl',
'timers',
'perf_hooks',
'worker_threads',
'encoding',
'fsevents',
'./fsevents.node',
// MWE node-fetch looks strange here, not sure what the effect of changing that would be
'node-fetch',
// jest is referred to in source code, like in TestUtils, but we don't want to ever bundle it up!
'jest',
'@testing-library/react',

View File

@@ -0,0 +1,40 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
*/
import {CallExpression} from '@babel/types';
import {NodePath} from '@babel/traverse';
// Core modules can be required as `node:fs` to bypass teh require cache
// https://nodejs.org/api/modules.html#core-modules
// It is not supported for "require" until Node v14.18.
// TODO: Remove this transform when we upgrade electron and node.js
const bypassRequireCachePrefix = 'node:';
module.exports = () => ({
name: 'change-require-to-electronRequire-in-electron-app',
visitor: {
CallExpression(path: NodePath<CallExpression>) {
const node = path.node;
if (
node.type === 'CallExpression' &&
node.callee.type === 'Identifier' &&
node.callee.name === 'require' &&
node.arguments.length === 1 &&
node.arguments[0].type === 'StringLiteral'
) {
const source = node.arguments[0].value;
if (source.startsWith(bypassRequireCachePrefix)) {
node.arguments[0].value = source.substring(
bypassRequireCachePrefix.length,
);
}
}
},
},
});

View File

@@ -13,6 +13,7 @@ import {default as getCacheKey} from './get-cache-key';
const presets = [require('@babel/preset-react')];
const plugins = [
require('./fsevents-dynamic-imports'),
require('./prefixed-node-requires'),
require('./electron-requires'),
require('./import-react'),
require('./app-flipper-requires'),

View File

@@ -12,6 +12,7 @@ import {default as doTransform} from './transform';
const presets = [require('@babel/preset-react')];
const plugins = [
require('./fsevents-dynamic-imports'),
require('./prefixed-node-requires'),
require('./electron-requires'),
require('./plugin-flipper-requires'),
require('./fb-stubs'),

View File

@@ -25,6 +25,7 @@ const presets = [
const plugins = [
require('./fsevents-dynamic-imports'),
require('./prefixed-node-requires'),
require('./electron-requires'),
require('./plugin-flipper-requires'),
require('./fb-stubs'),

View File

@@ -29,6 +29,7 @@ const presets = [
// (which effectively makes them external, as electronRequire === require, but not rolled up with Metro)
const plugins = [
require('./fsevents-dynamic-imports'),
require('./prefixed-node-requires'),
require('./electron-requires'),
require('./plugin-flipper-requires'),
require('./fb-stubs'),