Configure eslint to prevent imports from nested paths of externally provided modules
Summary: We have a list of modules that we do not bundle with the plugins, but provide externally to them from Flipper. For the mechanism to work correctly, we have to stop importing from nested paths of these modules. Reviewed By: mweststrate Differential Revision: D39776237 fbshipit-source-id: 06eae9bf9d5b11b48d2720bf592bfea749773847
This commit is contained in:
committed by
Facebook GitHub Bot
parent
982193df48
commit
d1158e2d02
@@ -54,7 +54,6 @@ import FpsGraph from '../chrome/FpsGraph';
|
||||
import UpdateIndicator from '../chrome/UpdateIndicator';
|
||||
import PluginManager from '../chrome/plugin-manager/PluginManager';
|
||||
import {showLoginDialog} from '../chrome/fb-stubs/SignInSheet';
|
||||
import SubMenu from 'antd/lib/menu/SubMenu';
|
||||
import constants from '../fb-stubs/constants';
|
||||
import {
|
||||
canFileExport,
|
||||
@@ -260,7 +259,7 @@ function ExtrasMenu() {
|
||||
className={menu}
|
||||
selectable={false}
|
||||
style={{backgroundColor: theme.backgroundDefault}}>
|
||||
<SubMenu
|
||||
<Menu.SubMenu
|
||||
popupOffset={[10, 0]}
|
||||
key="extras"
|
||||
title={<LeftRailButton icon={<SettingOutlined />} small />}
|
||||
@@ -288,7 +287,7 @@ function ExtrasMenu() {
|
||||
</Menu.Item>
|
||||
) : null}
|
||||
<Menu.Divider />
|
||||
<SubMenu title="Plugin developers">
|
||||
<Menu.SubMenu title="Plugin developers">
|
||||
<Menu.Item
|
||||
key="styleguide"
|
||||
onClick={() => {
|
||||
@@ -301,7 +300,7 @@ function ExtrasMenu() {
|
||||
onClick={() => openDeeplinkDialog(store)}>
|
||||
Trigger deeplink
|
||||
</Menu.Item>
|
||||
</SubMenu>
|
||||
</Menu.SubMenu>
|
||||
<Menu.Divider />
|
||||
{config.isFBBuild ? (
|
||||
<>
|
||||
@@ -324,7 +323,7 @@ function ExtrasMenu() {
|
||||
<Menu.Item key="help" onClick={() => setWelcomeVisible(true)}>
|
||||
Help
|
||||
</Menu.Item>
|
||||
</SubMenu>
|
||||
</Menu.SubMenu>
|
||||
</Menu>
|
||||
</NUX>
|
||||
{showSettings && (
|
||||
|
||||
@@ -9,10 +9,9 @@
|
||||
|
||||
import React, {useCallback} from 'react';
|
||||
import styled from '@emotion/styled';
|
||||
import {Button as AntdButton} from 'antd';
|
||||
import {Button as AntdButton, ButtonProps} from 'antd';
|
||||
|
||||
import Glyph, {IconSize} from './Glyph';
|
||||
import type {ButtonProps} from 'antd/lib/button';
|
||||
import {theme, getFlipperLib} from 'flipper-plugin';
|
||||
|
||||
type ButtonType = 'primary' | 'success' | 'warning' | 'danger';
|
||||
|
||||
Reference in New Issue
Block a user