From d0a05ad1a96241a5f35ce989c720ef010702f0df Mon Sep 17 00:00:00 2001 From: Luke De Feo Date: Tue, 29 Nov 2022 08:54:58 -0800 Subject: [PATCH] Use global id for debugcomponent id Summary: Global Id is stable as the component is rerendered. It is not stable if the whole component tree updates so we might want to deal with this in the future Reviewed By: lblasa Differential Revision: D41581346 fbshipit-source-id: 0c2834ba452ddcfc3e0a7392672825fc040901d9 --- .../uidebugger/litho/descriptors/DebugComponentDescriptor.kt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt b/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt index 127ae86f8..34dfeb592 100644 --- a/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt +++ b/android/plugins/litho/src/main/java/com/facebook/flipper/plugins/uidebugger/litho/descriptors/DebugComponentDescriptor.kt @@ -26,7 +26,7 @@ class DebugComponentDescriptor(val register: DescriptorRegister) : NodeDescripto * Debug component is generated on the fly so use the underlying component instance which is * immutable */ - override fun getId(node: DebugComponent): Id = System.identityHashCode(node.component) + override fun getId(node: DebugComponent): Id = node.globalKey.hashCode() override fun getName(node: DebugComponent): String = node.component.simpleName