From cf29bee5fa7d6f33ce926a3d7462f37c0be3f82b Mon Sep 17 00:00:00 2001
From: Pritesh Nandgaonkar <prit91@fb.com>
Date: Fri, 28 Aug 2020 07:16:57 -0700
Subject: [PATCH] Add analytics for cert exchange step

Summary: This diff adds analytics for events like uploading certs, zipping certs.Also logs the payload data received in trusted and untrusted request handlers. It will be helpful to debug the issues through this events.

Reviewed By: jknoxville

Differential Revision: D23374024

fbshipit-source-id: 6fa709bbf05e1b99ed1882be953abbd968eefc6e
---
 desktop/app/src/server.tsx                    |  9 +++++++++
 desktop/app/src/utils/CertificateProvider.tsx | 11 +++++++++--
 2 files changed, 18 insertions(+), 2 deletions(-)

diff --git a/desktop/app/src/server.tsx b/desktop/app/src/server.tsx
index c156f3c29..1d0a8310c 100644
--- a/desktop/app/src/server.tsx
+++ b/desktop/app/src/server.tsx
@@ -282,6 +282,13 @@ class Server extends EventEmitter {
     }
     const clientData: ClientQuery &
       ClientCsrQuery & {medium: number | undefined} = JSON.parse(payload.data);
+    this.logger.track('usage', 'trusted-request-handler-called', {
+      app: clientData.app,
+      os: clientData.os,
+      device: clientData.device,
+      device_id: clientData.device_id,
+      medium: clientData.medium,
+    });
     this.connectionTracker.logConnectionAttempt(clientData);
 
     const {
@@ -356,6 +363,8 @@ class Server extends EventEmitter {
       return {};
     }
     const clientData: ClientQuery = JSON.parse(payload.data);
+    this.logger.track('usage', 'untrusted-request-handler-called', clientData);
+
     this.connectionTracker.logConnectionAttempt(clientData);
 
     const client: UninitializedClient = {
diff --git a/desktop/app/src/utils/CertificateProvider.tsx b/desktop/app/src/utils/CertificateProvider.tsx
index 121c642a1..19beaf1c1 100644
--- a/desktop/app/src/utils/CertificateProvider.tsx
+++ b/desktop/app/src/utils/CertificateProvider.tsx
@@ -181,8 +181,15 @@ export default class CertificateProvider {
             archive.pipe(output);
             archive.finalize();
           });
-          await zipPromise;
-          await this.uploadFiles(certsZipPath, deviceId);
+
+          await reportPlatformFailures(
+            zipPromise,
+            'www-certs-exchange-zipping-certs',
+          );
+          await reportPlatformFailures(
+            this.uploadFiles(certsZipPath, deviceId),
+            'www-certs-exchange-uploading-certs',
+          );
         }
         return {
           deviceId,