From ce0d0384207523a1bf8471c90be9a401ce109b97 Mon Sep 17 00:00:00 2001 From: John Knox Date: Wed, 15 Jan 2020 08:05:56 -0800 Subject: [PATCH] Regularly report currently starred plugins Summary: Gives us visibility on how many / which plugins, people are starring. Reviewed By: mweststrate Differential Revision: D19408420 fbshipit-source-id: cb08e2a5f9d1b31ea03e6f7df8fa61db26611e91 --- src/dispatcher/tracking.tsx | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/src/dispatcher/tracking.tsx b/src/dispatcher/tracking.tsx index dd49c6d6d..065282568 100644 --- a/src/dispatcher/tracking.tsx +++ b/src/dispatcher/tracking.tsx @@ -61,18 +61,16 @@ export default (store: Store, logger: Logger) => { } ipcRenderer.on('trackUsage', () => { + const state = store.getState(); const { selectedDevice, selectedPlugin, selectedApp, clients, - } = store.getState().connections; + } = state.connections; const currentTime = Date.now(); - const usageSummary = computeUsageSummary( - store.getState().usageTracking, - currentTime, - ); + const usageSummary = computeUsageSummary(state.usageTracking, currentTime); store.dispatch(clearTimeline(currentTime)); @@ -84,8 +82,16 @@ export default (store: Store, logger: Logger) => { logger.track('usage', TIME_SPENT_EVENT, usageSummary[key], key); } + Object.entries(state.connections.userStarredPlugins).forEach( + ([app, plugins]) => + logger.track('usage', 'starred-plugins', { + app: app, + starredPlugins: plugins, + }), + ); + if ( - !store.getState().application.windowIsFocused || + !state.application.windowIsFocused || !selectedDevice || !selectedPlugin ) {