jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix build failure on OSS master (#3394)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/flipper/pull/3394

This diff caused OSS builds failing due to a FB plugin that requires emotion, instead of using it as peer dep. This introduced a duplicate dep, which doesn't get installed in OSS, causing patch-package for that package to fail. Changed it to a peer dep and removed the patch.

Reviewed By: aigoncharov

Differential Revision: D33975202

fbshipit-source-id: 1e82964988e944a28ecb46a10127ad9e13f743f7
This commit is contained in:
Michel Weststrate
2022-02-03 04:19:07 -08:00
committed by Facebook GitHub Bot
parent 7376774a95
commit ccea9058ef
1 changed files with 0 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
desktop/patches/@emotion+react++@emotion+cache+11.6.0.patch
View File

@@ -1,18 +0,0 @@
diff --git a/node_modules/@emotion/react/node_modules/@emotion/cache/dist/emotion-cache.cjs.dev.js b/node_modules/@emotion/react/node_modules/@emotion/cache/dist/emotion-cache.cjs.dev.js
index b1ad6ac..e577f28 100644
--- a/node_modules/@emotion/react/node_modules/@emotion/cache/dist/emotion-cache.cjs.dev.js
+++ b/node_modules/@emotion/react/node_modules/@emotion/cache/dist/emotion-cache.cjs.dev.js
@@ -158,9 +158,10 @@ var createUnsafeSelectorsAlarm = function createUnsafeSelectorsAlarm(cache) {
return;
}
- unsafePseudoClasses.forEach(function (unsafePseudoClass) {
- console.error("The pseudo class \"" + unsafePseudoClass + "\" is potentially unsafe when doing server-side rendering. Try changing it to \"" + unsafePseudoClass.split('-child')[0] + "-of-type\".");
- });
+ // messes up unit tests, and we don't do SSR!
+ // unsafePseudoClasses.forEach(function (unsafePseudoClass) {
+ // console.error("The pseudo class \"" + unsafePseudoClass + "\" is potentially unsafe when doing server-side rendering. Try changing it to \"" + unsafePseudoClass.split('-child')[0] + "-of-type\".");
+ // });
}
};
};