From ccbc4770f5c84b2226081443359057fd3987fd0b Mon Sep 17 00:00:00 2001 From: Andrey Goncharov Date: Thu, 23 Mar 2023 05:16:54 -0700 Subject: [PATCH] Log component stack if a component crashes Summary: Currently, component crashes are missing component stack traces. Without them, crash bot reports are impossible to debug. Reviewed By: ivanmisuno Differential Revision: D44331421 fbshipit-source-id: 0ebd160b4f2f64db40dae29dd9fc350d8d28d802 --- desktop/flipper-ui-core/src/ui/components/ErrorBoundary.tsx | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/desktop/flipper-ui-core/src/ui/components/ErrorBoundary.tsx b/desktop/flipper-ui-core/src/ui/components/ErrorBoundary.tsx index 3d2a646ff..95c7b9f1e 100644 --- a/desktop/flipper-ui-core/src/ui/components/ErrorBoundary.tsx +++ b/desktop/flipper-ui-core/src/ui/components/ErrorBoundary.tsx @@ -8,7 +8,7 @@ */ import {CodeBlock} from 'flipper-plugin'; -import {Component} from 'react'; +import {Component, ErrorInfo} from 'react'; import Heading from './Heading'; import Button from './Button'; import View from './View'; @@ -54,8 +54,8 @@ export default class ErrorBoundary extends Component< this.state = {error: null}; } - componentDidCatch(err: Error) { - console.error(err.toString(), 'ErrorBoundary'); + componentDidCatch(err: Error, errorInfo: ErrorInfo) { + console.error(err.toString(), errorInfo.componentStack, 'ErrorBoundary'); this.setState({error: err}); }