From cc946d12ec5a38b7d1fa61d8ffeb4f406c8e5093 Mon Sep 17 00:00:00 2001 From: Michel Weststrate Date: Fri, 22 Oct 2021 09:20:14 -0700 Subject: [PATCH] Disable Redux devTools Summary: I can't recall seeing anybody use Redux DevTools in the last 2 years. I don't think it adds much (most data in it is not serializable anyway), and disabling hopefully makes memory leaks / OOMs less likely on long debug sessions :) If someone misses it, feel free to bring it back. Reviewed By: passy Differential Revision: D31827421 fbshipit-source-id: 3c3836d4620a1ae431116df2de19a606672a6cd7 --- desktop/static/main.ts | 9 --------- 1 file changed, 9 deletions(-) diff --git a/desktop/static/main.ts b/desktop/static/main.ts index 659109f98..b77b2030c 100644 --- a/desktop/static/main.ts +++ b/desktop/static/main.ts @@ -192,21 +192,12 @@ app.on('ready', async () => { const { default: installExtension, REACT_DEVELOPER_TOOLS, - REDUX_DEVTOOLS, } = require('electron-devtools-installer'); // if set, try to download a newever version of the dev tools const forceDownload = process.env.FLIPPER_UPDATE_DEV_TOOLS === 'true'; if (forceDownload) { console.log('Force updating DevTools'); } - // Redux - try { - await installExtension(REDUX_DEVTOOLS.id, { - loadExtensionOptions: {allowFileAccess: true, forceDownload}, - }); - } catch (e) { - console.error('Failed to install Redux devtools extension', e); - } // React // Fix for extension loading (see D27685981) // Work around per https://github.com/electron/electron/issues/23662#issuecomment-787420799