jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move declaration of required permissions into core lib (#593)

Browse Source 
Summary:
If we move the permissions into the library itself, the manifest
merger will take care of adding them to consuming applications,
making setup instructions easier.

## Changelog

Move required permission declarations into flipper-core
Pull Request resolved: https://github.com/facebook/flipper/pull/593

Test Plan:
Using aapt we can dump the permissions of a sample app.
`$ANDROID_HOME/build-tools/29.0.2/aapt d permissions sample-debug.apk `
```
package: com.facebook.flipper.sample
uses-permission: name='android.permission.WRITE_EXTERNAL_STORAGE'
uses-permission: name='android.permission.INTERNET'
uses-permission: name='android.permission.ACCESS_WIFI_STATE'
uses-permission: name='android.permission.READ_EXTERNAL_STORAGE'
uses-permission: name='android.permission.FOREGROUND_SERVICE
```

Reviewed By: priteshrnandgaonkar

Differential Revision: D18006323

Pulled By: passy

fbshipit-source-id: c4cf28ee698faa3e2b631462f2953976135b299c
This commit is contained in:
Michael Evans
2019-10-18 06:42:10 -07:00
committed by Facebook Github Bot
parent c57718760d
commit cc19cc75ee
3 changed files with 4 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
android/sample/AndroidManifest.xml
View File

@@ -9,9 +9,7 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.facebook.flipper.sample">
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
<application
android:name=".FlipperSampleApplication"

3
android/src/main/AndroidManifest.xml
View File

@@ -8,4 +8,7 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.facebook.flipper">
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
</manifest>

9
docs/getting-started.md
View File

@@ -22,14 +22,7 @@ Once you start Flipper and launch an emulator/simulator or connect a device, you
## Setup your Android app
Add the following permissions to your `AndroidManifest.xml`. The SDK needs these to communicate with the desktop app on localhost via adb. It won't make any external internet requests.
```xml
<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_WIFI_STATE" />
```
It's recommended that you add the following activity to the manifest too, which can help diagnose integration issues and other problems:
It's recommended that you add the following activity to the manifest, which can help diagnose integration issues and other problems:
```xml
<activity android:name="com.facebook.flipper.android.diagnostics.FlipperDiagnosticActivity"