jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add support to build flipper-server from SandCastle

Browse Source 
Summary:
This refactors the flipper-server release script in such a way that it works the same as the normal release script, which solves two problems:

1) the official release script modifies versioned files, as it touches the package.json
2) it was slightly confusing that `flipper-server/static` was filled for release builds only, but not used in dev builds
3) running test:npx without running a release build before it, would fail with hard to comprehend errors. this has been solved now by removing that script and make it an arg of `build:flipper-server`

Also some further minor changes to prepare running a corresponding build / release job from SandCastle (later in this stack)

Reviewed By: nikoant

Differential Revision: D33297214

fbshipit-source-id: f6299aa982c3e59d1cc6479a93c56cbe4b57f85c
This commit is contained in:
Michel Weststrate
2021-12-24 07:15:15 -08:00
committed by Facebook GitHub Bot
parent efdf9d2d64
commit cbda298b9d
8 changed files with 121 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/flipper-server/src/startFlipperServer.tsx
View File

@@ -69,7 +69,7 @@ export async function startFlipperServer(
console.error('Failed to load keytar:', e);
}
const environmentInfo = await getEnvironmentInfo(staticPath, isProduction);
const environmentInfo = await getEnvironmentInfo(appPath, isProduction);
const flipperServer = new FlipperServerImpl(
{