jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

speed up verifying types deps by parallizing

Browse Source 
Summary: read pacakge.json files asyncronosly to speed up script execution

Reviewed By: LukeDefeo, passy

Differential Revision: D49188676

fbshipit-source-id: 55c1eeb8f62c6b3760f2a037592807c7b00af01d
This commit is contained in:
Anton Kastritskiy
2023-09-12 08:26:22 -07:00
committed by Facebook GitHub Bot
parent cd392929e0
commit cb4446d76c
1 changed files with 15 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
desktop/scripts/verify-types-dependencies.tsx
View File

@@ -46,15 +46,22 @@ type PackageJsonResult = {
unmatchedTypesPackages: UnmatchedLibType[]; unmatchedTypesPackages: UnmatchedLibType[];
}; };
function validatePackageJson(filepath: string): PackageJsonResult { function isValidTypesPackageName(x: [name: string, version: string]): boolean {
return x[0].startsWith('@types/') && !IGNORED_TYPES.has(x[0]);
}
async function validatePackageJson(
filepath: string,
): Promise<PackageJsonResult> {
try { try {
const json = JSON.parse(fs.readFileSync(filepath).toString()); const jsonBuf = await fs.promises.readFile(filepath);
const json = JSON.parse(jsonBuf.toString());
const deps: Record<string, string> = json.dependencies || {}; const deps: Record<string, string> = json.dependencies || {};
const devDeps: Record<string, string> = json.devDependencies || {}; const devDeps: Record<string, string> = json.devDependencies || {};
const typesPackages: Array<[string, string]> = [ const typesPackages: Array<[string, string]> = [
...Object.entries(deps).filter(([k, v]) => k.startsWith('@types/')), ...Object.entries(deps).filter(isValidTypesPackageName),
...Object.entries(devDeps).filter(([k, v]) => k.startsWith('@types/')), ...Object.entries(devDeps).filter(isValidTypesPackageName),
].filter((x) => !IGNORED_TYPES.has(x[0])); ];
const unmatchedTypesPackages: UnmatchedLibType[] = typesPackages const unmatchedTypesPackages: UnmatchedLibType[] = typesPackages
.map(([rawName, rawVersion]) => { .map(([rawName, rawVersion]) => {
@@ -106,9 +113,9 @@ async function main() {
const packageJsons = out.toString().trim().split('\n'); const packageJsons = out.toString().trim().split('\n');
const unmatched = packageJsons const unmatched = await Promise.all(
.map(validatePackageJson) packageJsons.map(validatePackageJson),
.filter((x) => x.unmatchedTypesPackages.length > 0); ).then((x) => x.filter((x) => x.unmatchedTypesPackages.length > 0));
if (unmatched.length === 0) { if (unmatched.length === 0) {
console.log('No issues found'); console.log('No issues found');