FlipperWebSocket

Summary:
Contains the implementation of FlipperWebSocket with any necessary changes to use it but without switching it on.

About SocketRocket and Cocoapods

A decision had to be made about whether to define different sub-specs, one for RSocket and another for SocketRocket.

I've opted to keep the podspec as is because:
- Keeps pod consumption as is.
- Makes easier to switch implementations using GK.
- There's no intention to keep RSocket going into the future. So, there's no point in creating a sub-spec only to remove it in the future.
- SocketRocket is a relatively small library so is not contributing to a significant increase in binary size.

If, as reviewer, you consider a subspec makes more sense, then feel free to reach out to discuss.

Reviewed By: fabiomassimo

Differential Revision: D30371791

fbshipit-source-id: 225c5b1de76aff1a6e36640a41765b963aaa2796
This commit is contained in:
Lorenzo Blasa
2021-08-26 09:01:17 -07:00
committed by Facebook GitHub Bot
parent 23682f914f
commit cac09d14aa
10 changed files with 650 additions and 33 deletions

View File

@@ -22,4 +22,6 @@ target 'Sample' do
pod 'OpenSSL-Universal', :configuration => 'Debug'
pod 'CocoaAsyncSocket', :configuration => 'Debug'
pod 'ComponentKit', '~> 0.31'
pod 'SocketRocket', '~> 0.6.0'
end

View File

@@ -28,6 +28,7 @@ PODS:
- FlipperKit/FBCxxFollyDynamicConvert
- FlipperKit/FBDefines
- FlipperKit/FKPortForwarding
- SocketRocket (~> 0.6.0)
- FlipperKit/CppBridge (0.104.0):
- Flipper (~> 0.104.0)
- FlipperKit/FBCxxFollyDynamicConvert (0.104.0):
@@ -76,6 +77,7 @@ PODS:
- libevent (2.1.12)
- OpenSSL-Universal (1.1.1100)
- RenderCore (0.31)
- SocketRocket (0.6.0)
- Yoga (1.14.0)
- YogaKit (1.18.1):
- Yoga (~> 1.14)
@@ -97,6 +99,7 @@ DEPENDENCIES:
- FlipperKit/SKIOSNetworkPlugin (from `../../FlipperKit.podspec`)
- libevent
- OpenSSL-Universal
- SocketRocket (~> 0.6.0)
SPEC REPOS:
https://github.com/CocoaPods/Specs:
@@ -112,6 +115,7 @@ SPEC REPOS:
- libevent
- OpenSSL-Universal
- RenderCore
- SocketRocket
- Yoga
- YogaKit
@@ -132,13 +136,14 @@ SPEC CHECKSUMS:
Flipper-Glog: 05579840e2750ec907ee2f81544f41ad76a7cae4
Flipper-PeerTalk: 116d8f857dc6ef55c7a5a75ea3ceaafe878aadc9
Flipper-RSocket: d9d9ade67cbecf6ac10730304bf5607266dd2541
FlipperKit: 9d78475d353d45f915523494908381afef1cf0c3
FlipperKit: fd70e8414049b3704be99710cbdb79fce8f39200
libevent: 4049cae6c81cdb3654a443be001fb9bdceff7913
OpenSSL-Universal: ebc357f1e6bc71fa463ccb2fe676756aff50e88c
RenderCore: 090beb17b5bff80b86929a7ceb49df789923d23a
SocketRocket: fccef3f9c5cedea1353a9ef6ada904fde10d6608
Yoga: cff67a400f6b74dc38eb0bad4f156673d9aa980c
YogaKit: f782866e155069a2cca2517aafea43200b01fd5a
PODFILE CHECKSUM: 154af3b1cdd6d65b1141c1215a3789297116c992
PODFILE CHECKSUM: 8f7b8c1a8e7cee47eaef4736990315bfc090e2af
COCOAPODS: 1.10.2