FlipperWebSocket

Summary:
Contains the implementation of FlipperWebSocket with any necessary changes to use it but without switching it on.

About SocketRocket and Cocoapods

A decision had to be made about whether to define different sub-specs, one for RSocket and another for SocketRocket.

I've opted to keep the podspec as is because:
- Keeps pod consumption as is.
- Makes easier to switch implementations using GK.
- There's no intention to keep RSocket going into the future. So, there's no point in creating a sub-spec only to remove it in the future.
- SocketRocket is a relatively small library so is not contributing to a significant increase in binary size.

If, as reviewer, you consider a subspec makes more sense, then feel free to reach out to discuss.

Reviewed By: fabiomassimo

Differential Revision: D30371791

fbshipit-source-id: 225c5b1de76aff1a6e36640a41765b963aaa2796

This commit is contained in:

Lorenzo Blasa

2021-08-26 09:01:17 -07:00

committed by

Facebook GitHub Bot

parent 23682f914f

commit cac09d14aa

10 changed files with 650 additions and 33 deletions

1

iOS/Podfile

View File

@@ -16,5 +16,6 @@ target 'FlipperKit' do
   pod 'glog', '~>0.3'
   pod 'Flipper-Folly', '~>2.2'
   pod 'CocoaAsyncSocket', '~>7.6'
   pod 'SocketRocket', '~> 0.6.0'
 end

FlipperWebSocket

1 iOS/Podfile Unescape Escape View File

1

iOS/Podfile

View File