From c8e5d95c41518ba0ebe7288eb9a0c4a83bf5f95d Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Thu, 2 Apr 2020 06:27:39 -0700 Subject: [PATCH] Show update indicator for non-FB builds Summary: Launcher was sort of a proxy for cases where we *wanted* to have an update mechanism but possibly couldn't use it, e.g. Windows at FB. This makes sure we can also show this in OSS. Reviewed By: nikoant Differential Revision: D20770804 fbshipit-source-id: 62d2dddf9cbd22d51098dda65eea50df420a3078 --- desktop/app/package.json | 2 +- desktop/app/src/chrome/UpdateIndicator.tsx | 3 ++- desktop/app/src/fb-stubs/config.tsx | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/desktop/app/package.json b/desktop/app/package.json index 790b10a0c..d4fdff83b 100644 --- a/desktop/app/package.json +++ b/desktop/app/package.json @@ -91,4 +91,4 @@ "optionalDependencies": { "7zip-bin-mac": "^1.0.1" } -} +} \ No newline at end of file diff --git a/desktop/app/src/chrome/UpdateIndicator.tsx b/desktop/app/src/chrome/UpdateIndicator.tsx index e167165f4..a55694c81 100644 --- a/desktop/app/src/chrome/UpdateIndicator.tsx +++ b/desktop/app/src/chrome/UpdateIndicator.tsx @@ -19,6 +19,7 @@ import {reportPlatformFailures} from '../utils/metrics'; import React from 'react'; import {shell} from 'electron'; import config from '../utils/processConfig'; +import isFBBuild from '../fb-stubs/config'; const Container = styled(FlexRow)({ alignItems: 'center', @@ -91,7 +92,7 @@ export default class UpdateIndicator extends React.PureComponent { } componentDidMount() { - if (isProduction() && config().launcherEnabled) { + if (isProduction() && (config().launcherEnabled || !isFBBuild)) { reportPlatformFailures( checkForUpdate(this.props.version).then((res) => { if (res.kind === 'error') { diff --git a/desktop/app/src/fb-stubs/config.tsx b/desktop/app/src/fb-stubs/config.tsx index 66c36f203..6d17f2d33 100644 --- a/desktop/app/src/fb-stubs/config.tsx +++ b/desktop/app/src/fb-stubs/config.tsx @@ -13,4 +13,5 @@ export default { showLogin: false, showFlipperRating: false, warnFBEmployees: true, + isFBBuild: false, };